Git Product home page Git Product logo

Comments (2)

alexey-katranov avatar alexey-katranov commented on May 10, 2024

@siddhesh , thank you for contribution and sorry for a long responce.

We have considered your patch and your idea is worth contributing. However, it looks like your idea can be applied for armv7a as well (as it also has the yield instruction), so we would prefer to have all arm-related code in one file. In addition, it will be easier to extend for further arm generations. Could you merge the newly added file into gcc_armv7.h (perhaps renamed to gcc_arm.h) using gcc_generic.h for all generations beside armv7a (for which you keep the current one) and implementing __TBB_Pause with your approach?

I would also recommend to open a pull request on github with your patch to simplify the communication process (we can add comments bound to the code).

from onetbb.

siddhesh avatar siddhesh commented on May 10, 2024

Thanks for your feedback. I'll rework my patch and send it to you shortly. A PR on github actually works much better for me too, I just assumed y'all preferred the traditional route since that's the documented method on the website :)

I'll close this issue and open a PR when I have the patch. Thanks!

from onetbb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.