Comments (2)
@siddhesh , thank you for contribution and sorry for a long responce.
We have considered your patch and your idea is worth contributing. However, it looks like your idea can be applied for armv7a as well (as it also has the yield
instruction), so we would prefer to have all arm-related code in one file. In addition, it will be easier to extend for further arm generations. Could you merge the newly added file into gcc_armv7.h
(perhaps renamed to gcc_arm.h
) using gcc_generic.h
for all generations beside armv7a (for which you keep the current one) and implementing __TBB_Pause
with your approach?
I would also recommend to open a pull request on github with your patch to simplify the communication process (we can add comments bound to the code).
from onetbb.
Thanks for your feedback. I'll rework my patch and send it to you shortly. A PR on github actually works much better for me too, I just assumed y'all preferred the traditional route since that's the documented method on the website :)
I'll close this issue and open a PR when I have the patch. Thanks!
from onetbb.
Related Issues (20)
- Compiling errors while building with Emscripten for WASM HOT 2
- My Cmake can't find TBB::tbb and TBB::tbbmalloc HOT 8
- What does `task_group_context` do? HOT 6
- Compile to WASM without threads? HOT 6
- The test_scheduler_mix hangs on !x86_64! HOT 17
- libtbb.so cannot be used with dlmopen() HOT 1
- When find() of tbb::concurrent_hash_map is used in parallel with iteration, the amount of data obtained is inconsistent with the size of the map? HOT 2
- tbb on wasm always executed on the main thread. HOT 13
- Possible data race reported by clang thread sanitizer HOT 6
- Disable TBBmalloc info message when compiling VS2022 HOT 2
- Is resumable task exception safe? HOT 4
- oneTBB 2021.11.0 APT package missing FindTBB.cmake HOT 6
- (Delete this issue) [Duplicate] Impossible to build the last version oneTBB 2021.11.0 on Windows with GCC 13.2
- Impossible to build the last version oneTBB 2021.11.0 on Windows with GCC 13.2 HOT 2
- Is there any reason we cannot implement a parallel_reduce for a rvalue range? HOT 2
- How to build TBB with static-libgcc and static-libstdc++ ? HOT 3
- Generating random numbers in parallel HOT 3
- oneTBB to schedule work execution on Intel GPUs HOT 1
- link fails building oneTBB from conan HOT 3
- `tbb::task_arena::enqueue` should at least document that execution order isn't guaranteed HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from onetbb.