Git Product home page Git Product logo

Comments (4)

bmyates avatar bmyates commented on May 9, 2024

Agreed, thanks for pointing this out. The intention here is that desc->pConstants is optional and nullptr should be an acceptable input. I'm working with our spec team to get the documentation updated, and we will post a fix to the validation layer soon. In the meantime, if you disable validation layer (or modify the code locally), passing nullptr for pConstants should work

from level-zero.

Kerilk avatar Kerilk commented on May 9, 2024

Yes, for now I use an empty ze_module_constants_t.

As far as the second issue is concerned (the check on the enum value), I have found several other instances where the test should be strict inequality < rather than <=, so the logic used to generate those seems problematic.

from level-zero.

bmyates avatar bmyates commented on May 9, 2024

Agreed that is an issue in multiple places. Another issue is that some flag fields are validated incorrectly. We will have a fix for this in the near future.

from level-zero.

Kerilk avatar Kerilk commented on May 9, 2024

These specific issues seem to have been fixed, I'll be closing this one to de-clutter.

from level-zero.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.