Node text becoming longer should move its child, not overlay about my-mind HOT 7 CLOSED

@alesviti Even when you select another node? For me, that solves the issue and moves all the elements involved.

from my-mind.

Yes. I meant while still editing. After moving away (or Enter) it moves OK.
I need to be more specific :-)

from my-mind.

@alesviti I would guess that the check for that occurs on node.select - if you want to change it to constantly check, or check on keyup, that would fix it. I would suggest the keyup method. @ondras your thoughts?

from my-mind.

I honestly see no real point in "fixing" this, but if that is what users want... can be done, naturally.

The node's value remains unchanged until you confirm that you are finished editing, either by hitting Enter or clicking another node. Only after this confirmation the node really changes its value and the relevant subtree gets redrawn.

This is the reason why nothing happens during editing: the re-layouting and re-drawing can be expensive and I wanted to prevent this being done too frequently (i.e. every time the value changes by pressing a key or so).

from my-mind.

@ondras I'm guessing this really only becomes computationally expensive when your total node count rises above a certain number? What if instead of checking on every keyup, there was a timer event that checked? This also seems like a more expensive option, but I'm just shooting ideas here.

My real suggestion is this: To avoid text overlay, when editing a node, use CSS to style that selected node to have a "background" color that is 100% opaque and overlays anything behind / under it. The node should also "grow" in size as text is entered. Think about how Excel / Numbers allows you to type text into a cell that will expand over all neighbor cells, and then on confirm will re-size everything to properly align.

from my-mind.

@samelawrence Perhaps I was just too afraid to re-layout stuff too frequently. I will perform some tests and adjust the feature as necessary.

from my-mind.

@ondras Right. Using my suggestion doesn't force any re-layout until confirmation. It just avoids text overlay.

from my-mind.