Git Product home page Git Product logo

Comments (5)

sywhb avatar sywhb commented on June 23, 2024 1
"og:image"

Yeah, that's right. We use the library provided by Obsidian to parse YAML file first to validate it and it will remove the outer quotation marks unless the value is a multiline string or some other cases

from omnivore.

jacksonh avatar jacksonh commented on June 23, 2024

I don't think that will work because what if the description has quotes in it?

from omnivore.

MasssiveJuice08 avatar MasssiveJuice08 commented on June 23, 2024

Fair point, although article descriptions can be manually changed in Omnivore, so as long as I change these to be YAML compliant then that shouldn't be an issue.


Would this be the reason why the quotation marks aren't being used? In data.json they are being escaped as special characters \"

data.json file showing quotations being escaped

from omnivore.

jacksonh avatar jacksonh commented on June 23, 2024

I don't think thats the issue, i suspect its because we validate in a YAML library and then spit out the validated YAML. But let me verify that with @sywhb

One question: why do you need the quotes? Without white space isn't og:image evaluated to the same thing in YAML as "og:image" or are they treated as different properties?

from omnivore.

MasssiveJuice08 avatar MasssiveJuice08 commented on June 23, 2024

One question: why do you need the quotes? Without white space isn't og:image evaluated to the same thing in YAML as "og:image" or are they treated as different properties?

I think I might not actually need the double quotations. I'm publishing my vault online using Obsidian-Digital-Garden, and I'm just following the docs here on setting metatags for a page, and the example screenshot shows the aforementioned YAML lines as being surrounded by double quotes. However, I tested on Omnivore article pages which have been published on my site and the metatags all render just fine. The page I actually used as an example in my first post even works – History of Morrowind - The Unofficial Elder Scrolls Pages (UESP).

So for my specific use case, this issue is resolved. It might be useful to keep open though for any other possible use-cases where you'd want the Omnivore frontmatter template to publish double quotations.

from omnivore.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.