bulk deleting function doesn't work about omnivore HOT 22 CLOSED

Going to assign this one to @sywhb to look into more. Based on the data here I do see the correct call being made, but the library item status not being updated on the backend.

from omnivore.

I think maybe the core error here is no:label creates an exception with our new search parser. /cc @sywhb

from omnivore.

@jacksonh I don't think so, see my updated reply #3292 (comment) w/o no:label the function doesn't work, neither.

from omnivore.

@sywhb confirmed fixed, thank you again.

from omnivore.

Are they still there if you refresh?

from omnivore.

Are they still there if you refresh?

yes there are, it's been over 2days and I've tried countless times:

1. use custom query to find out the items I don't want any more
2. select all or multiple
3. click the delete button
4. refresh webpage, nothing changes

from omnivore.

Do you mind opening the developer console and looking for any errors? Both on the console tab and the network tab? If there is anything private you can either obscure it in the screenshot or send through the feedback tool

from omnivore.

Thanks, it does look like everything went right there. Can you also try just a simple search like in:inbox with no label filters or anything to see if the items display?

from omnivore.

Going to delete this HAR file too as it includes some authentication info

from omnivore.

Thanks, it does look like everything went right there. Can you also try just a simple search like in:inbox with no label filters or anything to see if the items display?

it works for in:inbox

from omnivore.

@jostyee thanks. Can you add the search query here that isn't working?

from omnivore.

@jacksonh the query is in:archive author:admin , ty.

from omnivore.

hey @jacksonh, the delete function was failed because a recent change we made (default scope is in:inbox instead of in:all) and @jostyee was trying to delete items from archive folder so the params of the api were includes:id which converts to in:inbox includes:id and then no items were actually deleted

from omnivore.

ahhh so on the web client i should change this, taking a look at it now

from omnivore.

i think we probably should revert this change so defaults to in:all if no folder is defined but it creates some other problems with saved searches like no:label or type:file which we want to show only unarchived items

from omnivore.

ahhh so on the web client i should change this, taking a look at it now

no, it's something i changed in the backend here #3276

from omnivore.

Hmm, yeah i do think that patch is correct but we probably need to update defaults in a bunch of places.

from omnivore.

Hmm, yeah i do think that patch is correct but we probably need to update defaults in a bunch of places.

oh okay. like when you selected multiple items, the query should be in:all includes:id1,id2

from omnivore.

Yeah, or maybe whenever includes is used we should use in:all

from omnivore.

Yeah, or maybe whenever includes is used we should use in:all

yeah, sounds right

from omnivore.

Yeah, or maybe whenever includes is used we should use in:all

should be, otherwise tabs such as highlights won't show archive items, and I have to adjust the Obsidian sync plugin query to fetch them.

from omnivore.

@jostyee, we just fixed this. could you please check again?

from omnivore.