Comments (4)
Ok well the larger problem is that VS templates include comments as well. Should we remove those as well?
from generator-aspnet.
Maybe tooling in VS strips comments before JSON is used? That's common solution, e.g.:
https://github.com/sindresorhus/strip-json-comments
(that is: this could be the reason why VS templates have comments in JSON sources)
from generator-aspnet.
VS will already handle JSON with comments, so I don't think that's the issue, it's more if you're roundtripping with other editors which don't (or developers on other editors).
I'm in two minds, on the one hand, it's against the spec, on the other, comments are genuinely useful and the only editor that seems to choke right now is Sublime, so a workaround could be employed for that.
My current leaning is if JSON is going to be the project format, then it should be valid JSON.
Edit: Crockford's take on this:
I removed comments from JSON because I saw people were using them to hold parsing directives, a practice which would have destroyed interoperability. I know that the lack of comments makes some people sad, but it shouldn't.
Suppose you are using JSON to keep configuration files, which you would like to annotate. Go ahead and insert all the comments you like. Then pipe it through JSMin before handing it to your JSON parser.
https://plus.google.com/+DouglasCrockfordEsq/posts/RK8qyGVaGSr
from generator-aspnet.
PR #83 addresses the templates with comments in the project.json files
from generator-aspnet.
Related Issues (20)
- Remove 'usersecrets` subgenerator for RC HOT 1
- Update Docker template content for 2017RC HOT 1
- Update global.json generator/template for VS2017 RC HOT 1
- How to create controller in vscode using yo HOT 2
- [Possible Bug] Can't seem to run Yeoman generate project on Heroku HOT 10
- Can find project.json inside of new project HOT 18
- Log off should be Logout in mvc template
- Cant project in visual studio HOT 2
- The target "Restore" does not exist in the project HOT 2
- The specified framework 'Microsoft.NETCore.App', version '1.0.4' was not found HOT 5
- Subgenerators are not available HOT 5
- Can not bundle Js and css file in aspcore/angular2 HOT 2
- How to install previous generators HOT 1
- Bower is deprecated HOT 3
- double '<' character in csproj files HOT 1
- Error when using --version-current HOT 2
- Upgrade project templates to .NET Core 2.0 HOT 2
- Can't install generator-aspnet
- Sematic UI template - Index.cshtml content still has "ASP.NET MVC 5" or "ASP.NET 6" naming reference HOT 1
- Deprecate generator-aspnet package HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from generator-aspnet.