Git Product home page Git Product logo

Comments (7)

spboyer avatar spboyer commented on May 27, 2024

We have all of the templates local to the generator for subgenerators, what is everyone's thought?

from generator-aspnet.

peterblazejewicz avatar peterblazejewicz commented on May 27, 2024

If possible I think generator-asponet should use built-in copy feature of Yo's.

There is two level built-in solution in Yeoman to update generators AFAIK and keep users up-to-date with released, most recent versions:

#1
if user run yo she will be presented with option to update installed generators:

  Mocha 
  ──────────────
❯ Update your generators 
  Install a generator 

update:
generator-aspnet update is presented that way:

? 'Allo Piotr! What would you like to do? 
  ──────────────
  Run a generator
  Angular 
❯ Aspnet ♥ Update Available! 
  Bootstrap 
  Bootstrap Examples 
  Generator 
(Move up and down to reveal more choices)

#2
if generator-aspnet adds Yeoman's update plugin dependency the status of generator-aspnet will be checked on each run by Yeoman's itself:
https://github.com/yeoman/update-notifier

There is additional benefit of moving to use copy feature instead of fetching from git directly. During generator development that is not possible to work with locally updated content - samples are always fetched from remote upstream master - not from local repository used for development.

from generator-aspnet.

sayedihashimi avatar sayedihashimi commented on May 27, 2024

Yes I agree we should stop using .remote(). I think having all the files in the npm package is better so that offline works and so that you don't have to push to github to test template changes.

Update plugin sounds good as well.

from generator-aspnet.

peterblazejewicz avatar peterblazejewicz commented on May 27, 2024

The implementation for local templates/files can be as simple as:
https://gist.github.com/peterblazejewicz/9ae54b300b862b4e5320
I'd also think about bringing back tests for templ/files creation process.

from generator-aspnet.

spboyer avatar spboyer commented on May 27, 2024

@peterblazejewicz have you done this locally and tested?

from generator-aspnet.

peterblazejewicz avatar peterblazejewicz commented on May 27, 2024

@spboyer Yes, this is from my local branch. Can I bring back default Yeoman's testing structure to project? (by default yeoman-generator scaffolds tests for generator projects). I could investigate this.
I would not add local copy features yet unless covered by tests

from generator-aspnet.

spboyer avatar spboyer commented on May 27, 2024

.remote() removed and test coverage added for entire repo in latest PR -> #59

from generator-aspnet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.