Git Product home page Git Product logo

Comments (8)

gcolson avatar gcolson commented on May 27, 2024

I agree with @dznicol. We should be able, at least, to set the client_options.redirect_uri as a lambda / proc in order to add parameters on the fly to the url or things like that.
I also think that any parameter given to the request url should be added to the fixed callback url (ex. https://host.com/path?param1=value1&param2=value2 as request url should give https://host.com/path/callback?param1=value1&param2=value2 as callback url)

from omniauth_openid_connect.

stale avatar stale commented on May 27, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from omniauth_openid_connect.

makeready avatar makeready commented on May 27, 2024

+1 for this feature (if it's supported by the openid connect protocol)

from omniauth_openid_connect.

makeready avatar makeready commented on May 27, 2024

@dznicol the extra query parameters you give to omniauth in the initial request will be available to you at the return endpoint. I called mine "landing_url" to avoid the name collision with the oauth redirect url, and I can access it at the callback endpoint via request.env['omniauth.params']['landing_url']

from omniauth_openid_connect.

makeready avatar makeready commented on May 27, 2024

Using omniauth.params to control which page the user lands on should work most of the time...

That said, it would still be pretty nice to be able to define the redirect url dynamically. In my case I have a central domain handling the oauth, after which I have to send the user to a different subdomain matching their account, and my cookies are subdomain specific, so another internal auth mechanism is needed for the subdomain redirect. With dynamic redirect uri support in this gem (and if I can convince my provider to implement a wildcard whitelist on their side) I could have the user's subdomain manage the entire process.

One thing I thought of is iterating over all my subdomains on boot, registering a provider for each, but that seems pretty clunky.

from omniauth_openid_connect.

stale avatar stale commented on May 27, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from omniauth_openid_connect.

masciugo avatar masciugo commented on May 27, 2024

@makeready have you ever found a way to do that? thank you

from omniauth_openid_connect.

raivil avatar raivil commented on May 27, 2024

any updates on this issue?
I'd like to use dynamic callbacks uris as well, if possible.

from omniauth_openid_connect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.