'xcvbn_dictionary' test fails on any pattern match, not just by username or password about laravel-zxcvbn HOT 3 CLOSED

Yes, you seem to be 100% correct. This seems to come from that this package previously ran on a fork of https://github.com/bjeavons/zxcvbn-php, which hade additional methods which are not currently available.

We could either:

1. Fix the base issue, look for ways to only check against the user-input dictionary matches
2. Or just deprecate the xcvbn_dictionary-test and as you have suggested, work in the user input with the main password score in zxcvbn_min – and if xcvbn_dictionary is removed, a single zxcvbn-method can be available.

PRs are welcome! Will dig into this soon as well and refresh my memory (haven't done much work to this package the past 6 years... 😕 )

from laravel-zxcvbn.

No worries. I wrote a fix which I think works, I'm just running on my project for a bit to make sure it's good before I submit it for a PR.

I decided to just extend the "min" validator to optionally accept username and email and leave the dictionary one as it is, then change the documentation to clarify the function of the dictionary validator (which I don't think is especially useful but that's okay).

If you want to remove the dictionary validator you can but that'd be a breaking change. I tried to make the modification non-breaking so that package updates are safe.

Also I cannot get the tests to run for some reasons on my system, probably my own problem but I might ask you to run the new tests and make sure they pass.

from laravel-zxcvbn.

@GregPeden Finally got around to look into this and fix the issue. My guess is that it isn't relevant anymore, but here it is 😄 https://github.com/olssonm/laravel-zxcvbn/releases/tag/v5.0

from laravel-zxcvbn.