Git Product home page Git Product logo

Comments (17)

dajotim937 avatar dajotim937 commented on July 3, 2024

Same situation, but different error.
2024-01-18_02-17-18

Error from devtools
C:\Users\***\AppD…ipts\reading.js:848 Uncaught TypeError: Cannot read properties of null (reading 'classList')
    at goToImageCL (C:\Users\***\AppD…s\reading.js:848:12)
    at C:\Users\***\AppD…s\reading.js:1186:3
    at eachImagesDistribution (C:\Users\***\AppD…s\reading.js:3625:5)
    at goToIndex (C:\Users\***\AppD…s\reading.js:1184:2)
    at images.<computed>.onload (C:\Users\***\AppD…s\reading.js:4946:6)
goToImageCL			@ C:\Users\***\AppD…ipts\reading.js:848
(anonymous)			@ C:\Users\***\AppD…pts\reading.js:1186
eachImagesDistribution		@ C:\Users\***\AppD…pts\reading.js:3625
goToIndex			@ C:\Users\***\AppD…pts\reading.js:1184
images.<computed>.onload	@ C:\Users\***\AppD…pts\reading.js:4946
load (async)		
(anonymous)			@ C:\Users\***\AppD…pts\reading.js:4923
each				@ C:\Users\***\AppD…\dist\jquery.js:383
each				@ C:\Users\***\AppD…\dist\jquery.js:205
read				@ C:\Users\***\AppD…pts\reading.js:4917
openComic			@ C:\Users\***\AppD…scripts\dom.js:2102
await in openComic (async)		
(anonymous)			@ VM849:1
setTimeout (async)		
showNextComic			@ C:\Users\***\AppD…pts\reading.js:1585
stayInLine			@ C:\Users\***\AppD…ipts\reading.js:736
resized				@ C:\Users\***\AppD…pts\reading.js:2503

from opencomic.

dajotim937 avatar dajotim937 commented on July 3, 2024

UPD: or maybe alt+tab triggers something while loading next file.

Related: Alt+tab in fullscreen mode cause jump to some fixed position.

Screen record
2024-01-20_06-38-50.mp4

Also I added error message from devtools under screenshots.

from opencomic.

ollm avatar ollm commented on July 3, 2024

Thanks for the reports.

I have fixed most of the bugs (And those of the other issues), you can try the following build and test if there are still any that happen.

  • Improve stay in line in vertical reading 2a6254a
  • Some errors in scroll reading a4887c3
  • Some errors on reading in scroll 1485b25
  • Next chapter button not work inscroll mode if last page is smaller than the window and "Adjust to width" is enabled 2bbd49e
  • Error when pressing a key at startup 8f57f65

Build with fixes: https://mega.nz/file/Hf4WRTIL#_gfCjq91K3T8aTWCbjmxm2t0rcJwxnpyI3v4Elxl9Lk

This build also has some of the features requested in other issues.

  • Show the current reading title in app window 9520faa
  • Option to open file location of current reading from the file menu c9215dc
  • Setting to enable/disable go next/previous chapter with mouse scroll (Vertical reading) 37612bf

from opencomic.

dajotim937 avatar dajotim937 commented on July 3, 2024

Okay, thank you. I'll comment in relevant issues if I get those bugs again.

from opencomic.

dajotim937 avatar dajotim937 commented on July 3, 2024

Related: Alt+tab in fullscreen mode cause jump to some fixed position.

It's still there, but lesser than before. Mostly I can see only small movements but in general chapter stays on same position. But sometimes it still jumps.

Screen record
2024-01-27_18-15-49.mp4

from opencomic.

dajotim937 avatar dajotim937 commented on July 3, 2024

2024-01-27_18-23-00

Error from devtools

2024-01-27_18-26-02

Same situation. I click button on keyboard to open next chapter, alt+tab, got 3 same error window. In devtools there is 2 error message.

from opencomic.

dajotim937 avatar dajotim937 commented on July 3, 2024

2024-01-27_18-31-41

This one was not with alt+tab, but with F11 key (exit from fullscreen) when file was loading, I guess.

from opencomic.

ollm avatar ollm commented on July 3, 2024

It seems that the two errors occur when resizing the window before it loads (One when activating full screen and the other with alt+tab).

Try this build with this fix 770afba https://mega.nz/file/vCAj3RRD#qt89OlMa7jXHXtquckMMmTGeRmsjhYaTIP8iYHLWGXA

The full screen jump bug seems to be because a resize event is also triggered when using alt+tab in fullscreen, OpenComic tries to keep the image centered, but sometimes it doesn't seem to work correctly.

from opencomic.

dajotim937 avatar dajotim937 commented on July 3, 2024

Tested a bit. Looks like previous errors are gone. Now I don't get any error messages, but there is still error message in console.

2024-01-30_01-04-27

UPD: Well, I have read 50+ chapters with usual my read-flow and couldn't manage to get any other errors except error above.

from opencomic.

dajotim937 avatar dajotim937 commented on July 3, 2024

Said me, and immediately got an error when exiting from fullscreen while chapter was loading.

2024-01-30_05-27-30

from opencomic.

dajotim937 avatar dajotim937 commented on July 3, 2024

Not sure how I got this error. I think it happens while next chapter was loading and I click back button on the panel (left one button).

2024-01-30_08-09-12
2024-01-30_08-09-36

from opencomic.

dajotim937 avatar dajotim937 commented on July 3, 2024

2024-01-31_17-21-22

This one also didn't show any error messages, only in console.

from opencomic.

dajotim937 avatar dajotim937 commented on July 3, 2024

The full screen jump bug seems to be because a resize event is also triggered when using alt+tab in fullscreen

I guess this one also related to your message. Can't scroll past some position in fullscreen (F11).
Not webtoon mode (but still vertical), and used custom zoom in without "adjust to width" option. With this option everything's fine even in fullscreen.

2024-03-01_22-20-56.mp4

from opencomic.

dajotim937 avatar dajotim937 commented on July 3, 2024

One more error. Happens when folder has corrupted cbz file. In my case it was created file from torrent but it hasn't been download when I opened OpenComic (because I downloaded to folder that I added as master folder).

2024-03-07_14-51-04

from opencomic.

dajotim937 avatar dajotim937 commented on July 3, 2024

2024-03-18_03-22-02

Error from devtools
node:internal/validators:163 Uncaught TypeError: The "path" argument must be of type string. Received undefined
    at __node_internal_captureLargerStackTrace (node:internal/errors:490:5)
    at new NodeError (node:internal/errors:399:5)
    at validateString (node:internal/validators:163:11)
    at Object.normalize (node:path:305:5)
    at Readable.<anonymous> (C:\Users\***\AppD…-manager.js:1828:34)
    at Readable.emit (node:events:513:28)
    at addChunk (node:internal/streams/readable:324:12)
    at readableAddChunk (node:internal/streams/readable:297:9)
    at Readable.push (node:internal/streams/readable:234:10)
    at Object.bodyData (C:\Users\***\AppD…\src\maybe.js:77:12)
    at C:\Users\***\AppD…src\events.js:83:11
    at Socket.<anonymous> (C:\Users\***\AppD…\lifecycle.js:64:51)
    at Socket.emit (node:events:513:28)
    at addChunk (node:internal/streams/readable:324:12)
    at readableAddChunk (node:internal/streams/readable:297:9)
    at Readable.push (node:internal/streams/readable:234:10)
    at Pipe.onStreamRead (node:internal/stream_base_commons:190:23)
__node_internal_captureLargerStackTrace	@	node:internal/errors:490
NodeError	 @ node:internal/errors:399
validateString	 @ node:internal/validators:163
normalize	 @ node:path:305
(anonymous)	 @ C:\Users\***\AppD…ile-manager.js:1828
emit	         @ node:events:513
addChunk	 @ node:internal/streams/readable:324
readableAddChunk @ node:internal/streams/readable:297
Readable.push	 @ node:internal/streams/readable:234
bodyData	 @ C:\Users\***\AppD…-7z\src\maybe.js:77
(anonymous)	 @ C:\Users\***\AppD…7z\src\events.js:83
(anonymous)	 @ C:\Users\***\AppD…src\lifecycle.js:64
emit             @ node:events:513
addChunk	 @ node:internal/streams/readable:324
readableAddChunk @ node:internal/streams/readable:297
Readable.push	 @ node:internal/streams/readable:234
onStreamRead	 @ node:internal/stream_base_commons:190

from opencomic.

dajotim937 avatar dajotim937 commented on July 3, 2024

2024-03-18_03-44-49

Error from devtools
C:\Users\***\AppD…scripts\dom.js:1194 Error: incomplete frame
    at Object.readJson (C:\Users\***\AppD…pts\cache.js:229:33)
    at file.readCompressed (C:\Users\***\AppD…e-manager.js:207:20)
    at file.read (C:\Users\***\AppD…le-manager.js:65:24)
    at file.images (C:\Users\***\AppD…e-manager.js:445:36)
    at getFolderThumbnails (C:\Users\***\AppD…ipts\dom.js:1166:28)
    at C:\Users\***\AppD…ripts\dom.js:245:25
    at async Object.loadIndexPage (C:\Users\***\AppD…ripts\dom.js:778:19)
getFolderThumbnails       @ C:\Users\***\AppD…scripts\dom.js:1194
await in getFolderThumbnails (async)        
(anonymous)               @ C:\Users\***\AppD…\scripts\dom.js:245
Promise.then (async)        
loadFilesIndexPage        @ C:\Users\***\AppD…\scripts\dom.js:167
loadIndexPage             @ C:\Users\***\AppD…\scripts\dom.js:778
onclick                   @ index.html:1

from opencomic.

ollm avatar ollm commented on July 3, 2024

I'm going to close this for now, since I don't know which ones are solved or not, if there are some that still happen in the latest version v1.2.0, please open a new issue.

from opencomic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.