Git Product home page Git Product logo

Comments (8)

ollija avatar ollija commented on July 18, 2024 5

Thanks! I'm really glad this worked out.

It seems that on iPhone 7 a view listening to touch events with panResponder prevents the children from capturing touch events if
onMoveShouldSetPanResponder and
onMoveShouldSetPanResponderCapture
are true - but not on other iPhones.

I have absolutely no idea why this happens, but it could be fixed in this case because we don't need to capture both press and drag events at the same time.

So the fix was like, "don't capture drag events before the user has initiated the drag with a long-press, and don't capture press events while dragging"

from react-native-sortable-grid.

ollija avatar ollija commented on July 18, 2024

Sorry to hear that. It should work on an actual device just as well.
Have you tried running it with "JS Dev Mode"-option turned off and without remote JS debugging?

from react-native-sortable-grid.

booboothefool avatar booboothefool commented on July 18, 2024

@ollija Yes, I've tried running it in xcode Release build (Profiling mode), if that's what you mean.

from react-native-sortable-grid.

ollija avatar ollija commented on July 18, 2024

I tried running the examples of the library on an actual device (Iphone 6 IOS 10) with release build and they worked as expected. Unfortunately I don't have an Iphone 7 to test this with.

Is it possible for you to provide example code that produces this?

from react-native-sortable-grid.

booboothefool avatar booboothefool commented on July 18, 2024

@ollija The example code https://github.com/ollija/react-native-sortable-grid/blob/master/example/deletionExample.js is not working on my iPhone 7 (but works in simulator).

Here is a gif of me trying to initiate the drag, nothing happens 😔 :
2016-11-15_16_02_56

from react-native-sortable-grid.

ollija avatar ollija commented on July 18, 2024

Could you try with the latest version I just pushed and tell me if it worked?

from react-native-sortable-grid.

booboothefool avatar booboothefool commented on July 18, 2024

@ollija (before you pushed) I just tried it with my iPhone 5. It works perfectly with iPhone 5!

I will try out your new version on iPhone 7 now.

from react-native-sortable-grid.

booboothefool avatar booboothefool commented on July 18, 2024

@ollija After your latest push, it is now working beautifully on my iPhone 7! Thank you so much for your badass, one-of-a-kind library!

Out of curiosity, what was the issue? Is there something iPhone 7 does differently with touch handlers than previous versions?

from react-native-sortable-grid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.