seems to swallow child updates about react-native-sortable-grid HOT 5 CLOSED

@ollija Could you push a new version to npm please

from react-native-sortable-grid.

Hi @ollija, rn-sg only seems to be tracking children through this.items and _saveItemOrder(), which does not have any update mechanism. It's more of an "add unknown children" method to go along with _removeDisappearedChildren.

You could include updates by altering _saveItemOrder as follows:

  _saveItemOrder = (items) => {
    items.forEach((item, index) => {
      const foundKey = _.findKey(this.itemOrder, oldItem => oldItem.key === item.key);
      if (foundKey) {
        this.items[foundKey] = item;
      }
      else {
        this.itemOrder.push({ key: item.key, ref: item.ref, order: this.items.length });
        if (!this.initialLayoutDone) {
          this.items.push(item);
        }
        ...

but IMO it would be better to stay closer to convention and order/wrap children in render with React.children.map and this.props.children.sort, or something to that effect.

from react-native-sortable-grid.

I have spent maybe 3 hours trying to figure out what the fux I was doing which resulted in a lot of code being refactored into better looking code trying to solve it.

But I hit a brick wall and finally realized that maybe this module doesn't update children and here we are. :D

from react-native-sortable-grid.

Yeah, this threw me off. Very necessary update.

from react-native-sortable-grid.

also caught out by this, @ollija could you push an npm version?

from react-native-sortable-grid.