Use a better trim implementation about augment.js HOT 5 CLOSED

Thanks for the link, currently augment is using the trim2 implementation from that list which looks fairly good performance wise. I'll certainly do a few benchmarks on some more browsers with the suggested trim1 implementation though.

from augment.js.

I'm going to close this issue for now, after running benchmarks against the current implementation and the suggested implementation in IE there was nothing between the two versions performance wise.

from augment.js.

Have you looked at trim2, or did you benchmark trim10 and trim11, too? The one at the very end of the article seems to be the hottest candidate.

from augment.js.

I actually benchmarked trim1, trim2 (which is what is currently implemented) and trim 12, the one at the bottom of the article.

The difference between trim1 & trim2 was negligible. Trim 12 was much slower on any string that had any trailing spaces, and slightly quicker on strings with leading white spaces.

I've pushed the performance test that I did up on a branch, feel free to try it out yourself, perhaps my tests are flawed in some way?

from augment.js.

The tests look good, so yes, I officially draw back the issue :-)

from augment.js.