Comments (8)
Released in v3.0.0
. Thanks for the report and fix.
from react-faux-dom.
Hi @Olical, I just changed this line within Element.js
:
return props.style[styleCamelCase(name)]
to this:
return props.style[styleCamelCase(name)] || ''
but I don't know if it needs to be more subtle than that?
from react-faux-dom.
Pretty much all I was going to do + tests :)
On 30 Aug 2016 18:15, "Dominic Chambers" [email protected] wrote:
Hi @Olical https://github.com/Olical, I just changed this line within
Element.js:return props.style[styleCamelCase(name)]
to this:
return props.style[styleCamelCase(name)] || ''
but I don't know if it needs to be more subtle than that?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#68 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AATPXaChVpN8VWDpoBbID8hEu5myFJZRks5qlGVLgaJpZM4JwudN
.
from react-faux-dom.
I see, makes sense 😄. Would you like me to create that pull-request?
from react-faux-dom.
Okay, I've created a pull-request for this in case you haven't started it already.
from react-faux-dom.
Thanks @dchambers, I'll get this released ASAP.
from react-faux-dom.
Thanks @Olical, much appreciated 👍
from react-faux-dom.
That's working for me. Thanks again @Olical!
from react-faux-dom.
Related Issues (20)
- Append StyledComponents by d3? HOT 4
- Cannot append 'svg' properly with 'ReactFauxDOM' HOT 8
- Is it possible to get the stringified DOM? HOT 3
- Uncaught TypeError: (0 , _reactFauxDom.withFauxDOM) is not a function HOT 2
- Limitations HOT 2
- dangerouslySetInnerHTML - How can I set it? HOT 8
- getComputedTextLength() of a faux-element HOT 1
- Circle radius is NaN if adding d3 enter. HOT 9
- Failed to execute 'querySelector' on 'Document': '[object Object]' is not a valid selector. HOT 2
- Expose component propTypes and defaultProps.
- Expose component propTypes and defaultProps. HOT 2
- README may need update HOT 2
- TypeError: "text.node(...).getBBox is not a function" HOT 1
- Duplicate tick labels on axis update HOT 2
- d3.select(...).clone() report error HOT 2
- consider copy static properties to withFauxDOM HOC? HOT 1
- TypeError: node.compareDocumentPosition is not a function HOT 3
- minify react-faux-dom HOT 2
- Integrating React and d3.js with ReactFauxDOM displaying nothing on screen HOT 1
- componentWillMount deprecation HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-faux-dom.