Git Product home page Git Product logo

Comments (8)

Olical avatar Olical commented on May 18, 2024 1

Released in v3.0.0. Thanks for the report and fix.

from react-faux-dom.

dchambers avatar dchambers commented on May 18, 2024

Hi @Olical, I just changed this line within Element.js:

return props.style[styleCamelCase(name)]

to this:

return props.style[styleCamelCase(name)] || ''

but I don't know if it needs to be more subtle than that?

from react-faux-dom.

Olical avatar Olical commented on May 18, 2024

Pretty much all I was going to do + tests :)

On 30 Aug 2016 18:15, "Dominic Chambers" [email protected] wrote:

Hi @Olical https://github.com/Olical, I just changed this line within
Element.js:

return props.style[styleCamelCase(name)]

to this:

return props.style[styleCamelCase(name)] || ''

but I don't know if it needs to be more subtle than that?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#68 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AATPXaChVpN8VWDpoBbID8hEu5myFJZRks5qlGVLgaJpZM4JwudN
.

from react-faux-dom.

dchambers avatar dchambers commented on May 18, 2024

I see, makes sense 😄. Would you like me to create that pull-request?

from react-faux-dom.

dchambers avatar dchambers commented on May 18, 2024

Okay, I've created a pull-request for this in case you haven't started it already.

from react-faux-dom.

Olical avatar Olical commented on May 18, 2024

Thanks @dchambers, I'll get this released ASAP.

from react-faux-dom.

dchambers avatar dchambers commented on May 18, 2024

Thanks @Olical, much appreciated 👍

from react-faux-dom.

dchambers avatar dchambers commented on May 18, 2024

That's working for me. Thanks again @Olical!

from react-faux-dom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.