Comments (4)
@halestock: To keep with the coding conventions throughout this SDK, we suggest checking the AuthResult
status with the getStatus()
method. For example:
AuthApiClient authClient = new AuthApiClient(oktaSettings);
// Check if the user credentials are valid
AuthResult result = authClient.authenticate(username, password, someRelayState);
// Verify SUCCESS status
if (result.getStatus().equals("SUCCESS")) { /* Do something */ }
from okta-sdk-java.
@jmelberg-okta I'm referring to the fact that you cannot use the fields in AuthResult.Status to compare against when calling result.getStatus()
. Ideally, I would just use result.getStatus().equals(AuthResult.Status.SUCCESS)
instead of hardcoding "SUCCESS"
or defining these constants in my app. However, since they are not static, I would instead have to do:
AuthResult result = authClient.authenticate(username, password, someRelayState);
AuthResult.Status statuses = new AuthResult.Status();
// verify
if (result.getStatus().equals(statuses.SUCCESS)) { /* do something */ }
This seems to be pretty unnecessary. The fix is very straight forward, just defining the strings as static themselves:
public static class Status {
public static final String PASSWORD_WARN = "PASSWORD_WARN";
public static final String PASSWORD_EXPIRED = "PASSWORD_EXPIRED";
public static final String RECOVERY = "RECOVERY";
public static final String RECOVERY_CHALLENGE = "RECOVERY_CHALLENGE";
public static final String PASSWORD_RESET = "PASSWORD_RESET";
public static final String LOCKED_OUT = "LOCKED_OUT";
public static final String MFA_ENROLL = "MFA_ENROLL";
public static final String MFA_ENROLL_ACTIVATE = "MFA_ENROLL_ACTIVATE";
public static final String MFA_REQUIRED = "MFA_REQUIRED";
public static final String MFA_CHALLENGE = "MFA_CHALLENGE";
public static final String SUCCESS = "SUCCESS";
}
from okta-sdk-java.
@halestock: Good point. I have created a ticket with our team to update the SDK.
If you are interested in pushing this change yourself, please visit developer.okta.com/cla for more information.
Thanks!
from okta-sdk-java.
Closing as was implemented with PR #58
from okta-sdk-java.
Related Issues (20)
- Private Key is interpreted as PEMKeyPair instead of PrivateKeyInfo HOT 3
- Consistently thrown NoHttpResponseException's in 13.0.3 HOT 3
- An attempt to remove profile attribute value does not succeed HOT 2
- 13.0.2 missing UTF-8 support in Azure HOT 4
- Null LinksSelf in VerifyUserFactorResponse HOT 1
- Missing "List groups assigned to application" HOT 5
- OAUTH_AUTHORIZATION_POLICY PolicyType missing in latest spec HOT 9
- With 14.0.0 the application id is always null upon create HOT 2
- ClassNotFoundException with current dependencies in Gradle build HOT 4
- Okta Verify Fast Pass as an enrolled Factor is not returned HOT 8
- UserProfile equals() does not return true when objects are equal HOT 1
- Upgrade to 13.0.2 causes updateUser API to fail from attribute being mastered by a different system HOT 8
- `IdentityProviderApi` cannot properly deserialize `/ipds` responses HOT 1
- Create authorization server policy with type OAUTH_AUTHORIZATION_POLICY get error HOT 3
- IdP Discovery Policy not returned in listPolicyRules() HOT 2
- GroupsAPI - Custom group profile attributes missing HOT 3
- Several outdated dependencies
- OpenAPI spec missing some default role type HOT 3
- Invalid session HOT 3
- IdpPolicyRuleActionProvider needs the ability to set the provider id to be useful for creating IDP Routing Rules HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from okta-sdk-java.