Git Product home page Git Product logo

Comments (13)

bwalsh avatar bwalsh commented on August 15, 2024 1

@ahwagner Please review - I'll make a public instance available for review, hopefully by 2/4

Proposed changes

image

Refactored search

Default operator now and was or

Current

image

Proposed

image

Refactored table

Current

image

Proposed

image

from g2p-aggregator.

ahwagner avatar ahwagner commented on August 15, 2024

@bwalsh proposed changes look good to me.

from g2p-aggregator.

ahwagner avatar ahwagner commented on August 15, 2024

Some additional changes we should implement:

  • ensure source_url field URLs are presented as hyperlinks
    image
  • point the help documentation hyperlink in the intro paragraph to docs.cancervariants.org.
  • add brca to the list of excluded sources on the paper filter
  • fix auto-sort on evidence level
  • reduce filter drop-down menu options to preferentially sort or only display "short labels"

from g2p-aggregator.

ahwagner avatar ahwagner commented on August 15, 2024

@bwalsh added some feedback from our call today to this issue.

from g2p-aggregator.

bwalsh avatar bwalsh commented on August 15, 2024

@ahwagner

I've updated the staging site at 35.165.177.191.
The items checked off above have been addressed.
A new bucket with the data is available at https://s3-us-west-2.amazonaws.com/g2p-0.12/index.html
The drop-down menu options cannot be shortened. However, I have ensured that a filtered short lable eg evidence_lable does filter the results.

Let me know your thoughts

image

from g2p-aggregator.

ahwagner avatar ahwagner commented on August 15, 2024

These changes all look good. It appears that the "response" column broke, however; even records containing response_type data lack content in the relabeled column.

from g2p-aggregator.

ahwagner avatar ahwagner commented on August 15, 2024

@bwalsh did you have a chance to look at comment above?

from g2p-aggregator.

bwalsh avatar bwalsh commented on August 15, 2024

from g2p-aggregator.

ahwagner avatar ahwagner commented on August 15, 2024

Okay. I'm getting a weird error on my end–it looks like many of the columns are now broken, as is one of the interactive heatmaps.

image

from g2p-aggregator.

bwalsh avatar bwalsh commented on August 15, 2024

from g2p-aggregator.

ahwagner avatar ahwagner commented on August 15, 2024

Fantastic. I'm going to bump this to production for co-author review, with the caveat that the Table 2 p. normalization (this issue) isn't yet completed.

from g2p-aggregator.

ahwagner avatar ahwagner commented on August 15, 2024

Requests for JSON data from https://s3-us-west-2.amazonaws.com/g2p-0.12/index.html (e.g. https://s3-us-west-2.amazonaws.com/g2p-0.12/civic.json) return Access Denied errors. @bwalsh could you take a look at this?

from g2p-aggregator.

bwalsh avatar bwalsh commented on August 15, 2024

@ahwagner fixed. thanks for the catch

from g2p-aggregator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.