Plugin solution is not fishy about oh-my-fish HOT 17 CLOSED

That sounds cleaner to me. Reminds me of the old way of *.load files.

from oh-my-fish.

Absolutely, I was going to suggest this! It totally makes sense!

from oh-my-fish.

👍

from oh-my-fish.

if we're going this route, should't we move 'em to /functions/*.fish in the package directory?

from oh-my-fish.

@CoderStephen
Indeed it is, but changing the extension from .load to .fish. 👍

@bobthecow
My initial thought was backwards compatibility, but it's doable.
Later I thought about most plugins that only have one function, and we would now have an extra directory for a single function.

Well, I think it's going to be well structured if we go this route. So, let's do it. The init.fish and uninstall.fish should not go into the functions dir, right?

from oh-my-fish.

Later I thought about most plugins that only have one function, and we would now have an extra directory for a single function.

I also think that we would like to implement a package description file (or function), where plugins can declare dependencies. This extra function directory isn't a problem, it's the solution for separating concerns on plugin structure and loading just what the user will use.

from oh-my-fish.

Syntesizing what @bpinto is proposing + package.fish idea, a sample plugin directory structure would look like:

- plugin-foobar
  * init.fish
  * uninstall.fish
  * package.fish
  - functions
    * foo.fish
    * bar.fish

By only adding functions directory to autoloading paths we avoid loading unnecessary functions that are only used on load/init/uninstall.

from oh-my-fish.

That's it @derekstavis 👍

err... update, not really. :D

- plugin-foobar
  * init.fish
  * uninstall.fish
  - functions
    * foobar.fish
    * foo.fish
    * bar.fish

from oh-my-fish.

Hm, looks like it's identical, apart from just one file in functions

from oh-my-fish.

No package.fish file.

from oh-my-fish.

Reviving this discussion, what about this?

- plugin-foobar
  * init.fish
  * uninstall.fish
  * bundle
  - completions
    * foobar.fish
  - functions
    * foobar.fish
    * foo.fish
    * bar.fish

bundle can be used for declaring dependencies, like package.json.

from oh-my-fish.

if we leave $PACKAGENAME.fish support in, plugins will work whether they've updated or not.

from oh-my-fish.

I think adding support for $PACKAGENAME.fish is a temporary solution, but we should migrate them to improve loading time.

from oh-my-fish.

from oh-my-fish.

Nice. 👍

from oh-my-fish.

Time to migrate yours @CoderStephen ? 👍

from oh-my-fish.

Indeed. In the next few days.

from oh-my-fish.