Git Product home page Git Product logo

Comments (6)

GoogleCodeExporter avatar GoogleCodeExporter commented on August 24, 2024

Original comment by [email protected] on 25 Jul 2009 at 12:05

  • Changed state: Accepted
  • Added labels: Milestone-Eventually

from dwarftherapist.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 24, 2024
This isn't a bug. The game allows arbitrarily long profession names and 
nicknames.

Original comment by [email protected] on 2 Aug 2009 at 8:57

  • Changed state: Invalid

from dwarftherapist.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 24, 2024
This is actually a bug. Kind of a nasty one at that. If custom professions 
longer than 
15 characters are entered, it's actually overrunning a std::string buffer in 
the game. 
This can cause corruption but doesn't 99% of the time.

Will have to do something about this...

Original comment by [email protected] on 11 Sep 2009 at 12:18

  • Changed state: Accepted

from dwarftherapist.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 24, 2024
To fully match up with what VC++ does with strings, you need to track the 
original
string length on read.  If the original string is empty or < 16 bytes, you can 
safely
write back anything up to 16 bytes.  If the original string is 16+ bytes, you 
can
safely write back up to that length (since it goes into a buffer allocated 
separately
from the std::string structure.)  That is, I could customize the profession 
through
df to 24 'A's and then replace that with a 24-character string through DT, and 
it
should be able to write that back with no corruption.

And, of course, none of this works on Linux :(

Original comment by [email protected] on 28 Nov 2009 at 4:41

from dwarftherapist.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 24, 2024
A visual solution would be to have the data entry box:
* Presented in a mono-spaced font
* Surrounded by a bitmap that is one color on the left and another color just 
past
valid input.

This would mark the end of text length for easy editing, but not impose a hard 
limit.

Original comment by [email protected] on 18 May 2010 at 7:29

from dwarftherapist.

GoogleCodeExporter avatar GoogleCodeExporter commented on August 24, 2024

Original comment by [email protected] on 13 Oct 2010 at 4:41

from dwarftherapist.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.