Git Product home page Git Product logo

Comments (5)

poteto avatar poteto commented on May 27, 2024 1

this might be possible... I'll whip something up when I wake up

from ember-parachute.

offirgolan avatar offirgolan commented on May 27, 2024

@mwpastore although this would be nice to have, query param serialization / deserialization can happen before the controller is even created so I dont believe this would be currently possible.

from ember-parachute.

poteto avatar poteto commented on May 27, 2024

I had a bit of a think about this, and it seems to me like the issue is really about where this kind of validation of query params should live. In my mind, the serialize / deserialize functions are purely for presentation of the query parameter in the URL only. Validation or other business logic should happen before the value is set on the controller. In your case, you should be validating the item's index in the array before setting the value.

Does that make sense? @mwpastore

from ember-parachute.

mwpastore avatar mwpastore commented on May 27, 2024

@poteto Thanks for your thoughts and work on this. I understand what you're saying and basically agree, but if a user first browses to the site with e.g. ?index=3, ideally there would be a way to sanity check that index against the array it's selecting into. Perhaps that's an argument for having a separate setter function in the controller instead of enhancing the deserialize QP function. Either way it would be good to figure out and document this use case.

from ember-parachute.

offirgolan avatar offirgolan commented on May 27, 2024

@mwpastore the idea behind the serialize/deserialize is not to do any business logic but only to format how it should look in the URI. The business logic should be done before setting the query parameter in the first place.

from ember-parachute.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.