Git Product home page Git Product logo

Comments (7)

aaron-pratt avatar aaron-pratt commented on May 27, 2024

I should also add that the previous release was working fine...

from pyreadr.

ofajardo avatar ofajardo commented on May 27, 2024

hi there @aaron-pratt

Sorry for the confusion. As stated in the change-log (look for a change log file in the repo), I changed the compilation method from MSVC (MS Build Tools) to MingW. There is a document compilation on windows on the top of the repo and it explains how to do it (it's easier, but you would depend on conda instead of MSVC).

Why are you building from source in first place? If you install with pip or conda you will get immediately a pre-compiled wheel so that you don't need to compile.

The reason why I changed the compilation method is because the C library librdata is not compatible with MSVC. I was manually patching the copy I have here of librdata to work with MSVC; however in this last version a new feature has been introduced (handling bzip compression), where the patch was no longer working, so my way to move forward has been to change to MingW that is fully compatible with librdata. In addition doing the manual patching everytime I need to update librdata is error prone and tiring, while now I can simple copy and paste. In some long future I hope that they make librdata officially compatible with MSVC.

If you would insist on keep compiling with MSVC (why?), there is a document librdata jamovi differences that explain in which lines of librdata write what to make it to work with MSVC. You can take a fork of pyreadr, apply that and also take out the bzip compression from setup.py and you would get back to normal. I can help there but I wouldn't do it unless you have a very good reason to do so.

Hope it helps.

from pyreadr.

aaron-pratt avatar aaron-pratt commented on May 27, 2024

Hi @ofajardo,

If you look to the top of the output above, this is using pip... Maybe the pre-compiled wheel for Windows has the issue?

Looking through the errors it looks to be driven from a whole bunch of syntax issues that the MSVC is not liking at all...

Appreciate all the help btw!

from pyreadr.

ofajardo avatar ofajardo commented on May 27, 2024

ahhhh, the wheels for python on windows are not in PyPi !!! (actually only the one for python 3.8).

Sorry for the confusion before. Let me fix the wheels, upload to pypi and then all should be fine.

from pyreadr.

ofajardo avatar ofajardo commented on May 27, 2024

OK ready. Can you please try again?

Since you have already a cached wrong version (the source distribution) maybe use --no-cache option with pip to be sure it gets the correct wheel.

You don't need MS Build Tools at all, just do it in a normal (or anaconda) command line prompt.

from pyreadr.

aaron-pratt avatar aaron-pratt commented on May 27, 2024

Perfect! All working again now :)

Thanks for the speedy response.

from pyreadr.

ofajardo avatar ofajardo commented on May 27, 2024

thanks for reporting!

from pyreadr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.