Git Product home page Git Product logo

Comments (3)

AlexanderZender avatar AlexanderZender commented on May 27, 2024

Fix for the first issue is to ignore nan values:

image

from explainerdashboard.

oegedijk avatar oegedijk commented on May 27, 2024

Hi @AlexanderZender ,nice catch! I'm on holiday until the end of the month so away from keyboard, but if you want to try to write up a PR I can see if I can have a look at it and get it released once I'm back

from explainerdashboard.

AlexanderZender avatar AlexanderZender commented on May 27, 2024

I found the issue(?) with my changed columns and values.
The model applied its preprocessing and these changes got applied to self.X in the explainer class.
I currently solved it by making a copy of the passed x in my Wrapper class:
image

The question is, should the user ensure this, or should explainer dashboard maybe only pass copies down to the model in the first place?
I can see that sometimes copies are indeed passed by explainer dashboard e.g.
image

I would suggest to only pass copies, to avoid potential issues with other models or pipeline in which the user might not have influence or doesnt want to add a wrapper.

@oegedijk If you dont mind i will open a PR in a bit with both things

from explainerdashboard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.