SyntaxError with accentuated filenames about react-s3-uploader HOT 5 CLOSED

My bad, I'm pretty sure it's because I don't escape them while getting the signed url from my server ...

from react-s3-uploader.

Must be this line that is failing.

There must be restrictions on the encoding of characters for setting headers or something (I'm really not sure). Looks like this StackOverflow question says that only US-ASCII characters are allowed.

I went looking at the jquery source code to see if they do anything special when setting request headers, and here where they take in the headers, and here where they set them, neither does any encoding.

You could try to encodeURIComponents on the filename, but not sure that would be correct. If you come up with a solution, and want to submit a PR (or let me know what the solution is, and I can plug it in), we'd love to have it.

Thanks.

from react-s3-uploader.

http://stackoverflow.com/a/22935139/2726340
This replacement is basically what I'd like to implement, as I don't really want to decode/encode everytime either on server or client side. As it's not really standard, I don't think I should submit it... Though I'd like to have your input on how I could plug it in, as I "just" import your component, I can't manage this on my end... Or could I ?

Thanks

from react-s3-uploader.

Probably would need a PR for this. Just need to do some extra work on this line: https://github.com/odysseyscience/react-s3-uploader/blob/master/s3upload.js#L63

from react-s3-uploader.

Pushed v1.2.0 that addresses this issue.

from react-s3-uploader.