[BUG]: Octokit v4 types about octokit.js HOT 8 CLOSED

seems stil：

my tsconfig:

{
  "compilerOptions": {
    "target": "ESNext",
    "module": "ESNext",
    "moduleResolution": "Node",
    "esModuleInterop": true,
    "strict": true,
    "resolveJsonModule": true,
    "declaration": true,
    "outDir": "dist",
    "skipLibCheck": true,
    "rootDir": "src"
  },
  "include": ["src", "types", "bin"]
}

Currently using 4.0.2, works fine on 3.1.2.

from octokit.js.

Please read up https://www.typescriptlang.org/docs/handbook/modules/reference.html#packagejson-exports
and https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c

This is an error with your tsconfig.json, you have to use either node16 or nodenext modules and moduleresolution

from octokit.js.

The original author hasn't responded, and given that #2676 was resolved and that this seems like a case of misconfigured TypeScript, I will close this

from octokit.js.

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

from octokit.js.

What is your tsconfig?

from octokit.js.

can you test again with the latest version? We had a build config bug that was resolved in v4.0.2

from octokit.js.

Oh very sorry for taking up your time because of my problem, I made changes based on your suggestions and have fixed the problem, thanks!

from octokit.js.

Yes, my project was not correctly in ESM, not in terms of typescript. After applying NodeNext and absolute imports octokit works fine.

from octokit.js.