Git Product home page Git Product logo

Comments (2)

ocornut avatar ocornut commented on August 24, 2024

Should be fixed by 0561d70.

  • I was first puzzled that the "window_popup_menu" test was breaking but I realized the breakage was specifically under a #if !IMGUI_BROKEN_TESTS block aka was testing an undesirable behavior, which we now fixed.
  • Then "window_popup_nested_interruptions" was breaking but it only highlighted that my first fix attempt was broken, at it accidentally allowed to close a nested modal by focusing the previous one. The correct fix is to call ClosePopupsOverWindow(GetTopMostPopupModal(), ...) and not ClosePopupsOverWindow(blocking_modal);.

Those specifics tests are a bit laborious to work but they are always helpful.

from imgui.

ocornut avatar ocornut commented on August 24, 2024

Also added a simpler "window_popup_close_with_void" test:
ocornut/imgui_test_engine@f75f8ed

from imgui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.