Git Product home page Git Product logo

Comments (4)

nautaa avatar nautaa commented on June 9, 2024

Thanks for the feedback and fix, I was able to reproduce it on ubuntu 20.04(ref: https://github.com/nautaa/oceanbase/actions/runs/8580887461/job/23517789556), but it compiles fine here on centos7(ref: https://github.com/nautaa/oceanbase/actions/runs/8581083276/job/23517808137).

Can you submit a separate PR for this issue? The target branch is selected as 4.2.x. Actually oblogminer_dev is a mirrored branch for 4.2.x.

from oceanbase.

zztaki avatar zztaki commented on June 9, 2024

Thanks for the feedback and fix, I was able to reproduce it on ubuntu 20.04(ref: https://github.com/nautaa/oceanbase/actions/runs/8580887461/job/23517789556), but it compiles fine here on centos7(ref: https://github.com/nautaa/oceanbase/actions/runs/8581083276/job/23517808137).

Can you submit a separate PR for this issue? The target branch is selected as 4.2.x. Actually oblogminer_dev is a mirrored branch for 4.2.x.

Thank you for your review. I will submit a separate PR for this in 4.2.x tomorrow. :)
Does it mean that this enhancement #1912 is also above 4.2.x?

from oceanbase.

nautaa avatar nautaa commented on June 9, 2024

Thanks for the feedback and fix, I was able to reproduce it on ubuntu 20.04(ref: https://github.com/nautaa/oceanbase/actions/runs/8580887461/job/23517789556), but it compiles fine here on centos7(ref: https://github.com/nautaa/oceanbase/actions/runs/8581083276/job/23517808137).
Can you submit a separate PR for this issue? The target branch is selected as 4.2.x. Actually oblogminer_dev is a mirrored branch for 4.2.x.

Thank you for your review. I will submit a separate PR for this in 4.2.x tomorrow. :) Does it mean that this enhancement #1912 is also above 4.2.x?

yep. These PRs will eventually try to merge in the internal branch.

from oceanbase.

zztaki avatar zztaki commented on June 9, 2024

Thanks for the feedback and fix, I was able to reproduce it on ubuntu 20.04(ref: https://github.com/nautaa/oceanbase/actions/runs/8580887461/job/23517789556), but it compiles fine here on centos7(ref: https://github.com/nautaa/oceanbase/actions/runs/8581083276/job/23517808137).
Can you submit a separate PR for this issue? The target branch is selected as 4.2.x. Actually oblogminer_dev is a mirrored branch for 4.2.x.

Thank you for your review. I will submit a separate PR for this in 4.2.x tomorrow. :) Does it mean that this enhancement #1912 is also above 4.2.x?

yep. These PRs will eventually try to merge in the internal branch.

I get it! Have a good night~

from oceanbase.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.