[BUG]索引扫描删除记录不能完全删除 about miniob HOT 6 OPEN

Thanks.
Do you have some suggestions? Or would you like to create a pull request?

from miniob.

Thanks. Do you have some suggestions? Or would you like to create a pull request?

To minimize code structure modifications as much as possible, my current solution is to add a boolean property called idx_need_increase_ within the IndexScanPhysicalOperator class, with a default value of true. I would also provide methods set_idx_need_increase() and get_idx_need_increase(). In the DeletePhysicalOperator::next() function, if the record deletion is successful, I would attempt to cast the PhysicalOperator* child into an IndexScanPhysicalOperator*. If the casting is successful, I would then call set_idx_need_increase() to set it to false. In the next_entry() function, I would use the provided idx_need_increase parameter to decide whether to perform the iter_index_++ operation.

If you think this approach is feasible, I can submit a pull request (PR), or you can provide me with some suggestions.

from miniob.

Thanks for your suggestion. It looks not a perfect solution.

1. Your solution only suit for deletion and cannot used in insertion scenario
2. Cast the child to specific type is not a generic method.

Do you know the method that some real-database uses, such as mysql, postgresql?
And it also looked like std::iterator with insert/delete.

from miniob.

Do you mean that, similar to using erase() for deleting elements in a vector, it returns a valid iterator? I'm not very familiar with how MySQL/PostgreSQL implement this feature. Could you provide me with some keywords so that I can try to implement this solution?

from miniob.

std::iterator cannot deal with erase or insert correctly.
I'm sorry that I am not familiar with mysql/postgresql too and I cannot provide any useful information too.
I will trace this issue and if you have any other ideas, discussion is welcome.

from miniob.

Is it possible to fix this bug? The test samples in the competition involve this issue, and it won't pass the test if it's not fixed.

from miniob.