Git Product home page Git Product logo

Comments (3)

gs0510 avatar gs0510 commented on August 17, 2024

@shreyaswikriti Were you able to figure out what the Fixme implies? @pitag-ha and I looked at it but couldn't decipher what the FIXME meant :)

from v2.ocaml.org.

shreyaswikriti avatar shreyaswikriti commented on August 17, 2024

@gs0510, what I understand from the functions
&& not(Utils.KMP.is_substring ~pat:a.name feed_author)
&& not(Utils.KMP.is_substring ~pat:feed_author a.name)
is:
this line is searching that a.name should not be present in feed_author and vice versa.
using is_substring function, it returns true even if the substring is present in between the string. Setting word boundaries returns true only if the substring is present as a whole word. Here is the explanation:
Suppose feed_author='swikriti'
a.name='shreyaswikriti'
not(Utils.KMP.is_substring ~pat:feed_author a.name) -->not(true)-->false
But there can be a possibility that this can be the name of two different persons. Giving false results won't generate a new feed_author.
Now checking using word boundary :
it results that 'swikriti' has no word boundary in 'shreyaswikriti' because 'shreyaswikriti' doesn't start with the word 'swikriti'
this gives the result that a new feed_author can be formed with the name 'swikriti'.

from v2.ocaml.org.

gs0510 avatar gs0510 commented on August 17, 2024

That makes sense @shreyaswikriti! You can go ahead and fix this :)

from v2.ocaml.org.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.