Does MPP escape the command properly? about mpp-language-blender HOT 9 CLOSED

I discovered this recently. It's because I use Sys.command and it calls sh. So it works fine when sh is a link to bash or any not-too-poor shell, but it doesn't work when sh is a link to dash or if sh is a real old fashioned sh or equivalent.

I have to fix that but 2 ideas that I have are not good and another is kind of a pain to implement. I'll investigate more soon.

Philippe Wang

On 7 nov. 2013, at 11:59, Christophe Troestler [email protected] wrote:

If I run

mpp -so '((!' -sc '!))' -son '{{!' -scn '!}}' -soc '' -scc '' -sec '' -sos '{{}}' -its -set "filename=site/index.md" -set "page=ocaml.org/index.html.tmp" tpl/main.mpp -o "ocaml.org/index.html"
in a terminal, I get

sh: 1: Syntax error: redirection unexpected
The strings are properly escaped. Is it possible that the problem comes from mpp trying to execute commands and not escaping properly the arguments? (No time to investigate right now)

—
Reply to this email directly or view it on GitHub.

from mpp-language-blender.

IMHO, it is rather urgent that it is solved because this bug prevents people on up-to-date GNU/Linux systems to compile ocaml.org.

from mpp-language-blender.

I agree.

The temporary hack is ln -sf bash /bin/sh.

from mpp-language-blender.

I think I've found a good way to fix this!

from mpp-language-blender.

On Thu, 7 Nov 2013 05:46:12 -0800, Philippe Wang wrote:

I agree.

The temporary hack is ln -sf bash /bin/sh.

;-)))

from mpp-language-blender.

The new version will be in opam when ocaml/opam-repository#1271 is merged.

Thank you Christophe.

from mpp-language-blender.

I'm re opening this issue because I need further investigation: it seems that either I didn't really fix the bug, or there's a similar bug elsewhere... or I used the same "modern-shell feature" in some MPP code for ocaml.org.

from mpp-language-blender.

I confirm that indeed

mpp -so '((!' -sc '!))' -son '{{!' -scn '!}}' -soc '' -scc '' -sec '' -sos '{{<' -scs '>}}' -its  -set "filename=site/index.md" -set "page=ocaml.org/index.html.tmp" tpl/main.mpp -o "ocaml.org/index.html" 

still ends with

sh: 1: Syntax error: redirection unexpected

from mpp-language-blender.

(closed with 904dc97 )

from mpp-language-blender.