[emacs] merlin-ident-under-point confused by polymorphic variants about merlin HOT 3 CLOSED

gasche [email protected] writes:

When the point is on ``List, C-c C-t` sends the identifier `List` to the merlin process, which then returns the signature of the `List` module.

It should be fixed in master. I defined a new kind of things ocaml-atom
that can be extended if needed.

from merlin.

Looking at your change only (not tested yet), this doesn't follow OCaml lexical conventions: what about _ in identifiers, or Foo`Bar` being parsed as Foo (Bar)?

I think there is a wider question at hand: what is an "atom" in your model? The OCaml grammar does not consider ``Stringa valid identifier, it is the identifierString`, as a tag name, preceded by the literal ``` indicating a polymorphic variant tag. How would you split `obj#foo` when the point is on `foo`? Would you fail, send `foo`, or `#foo` (maybe the protocol needs a way to specify grammatical namespaces such as polymorphic tag names and function names), or `obj#foo` (related to feature request #6 ) ?

from merlin.

Fixed in experimental.

from merlin.