Build against ocaml-4.08.0+beta3 fails about flexdll HOT 10 CLOSED

The compat layer should be updated, but can I ask what you mean by "fails"?

from flexdll.

Here you go:

>ocaml
        OCaml version 4.08.0+beta3

# Pervasives.compare;;
Line 1, characters 0-18:
1 | Pervasives.compare;;
    ^^^^^^^^^^^^^^^^^^
Alert deprecated: module Stdlib.Pervasives
Use Stdlib instead.

If you need to stay compatible with OCaml < 4.07, you can use the
stdlib-shims library: https://github.com/ocaml/stdlib-shims

from flexdll.

That's not failing, it's displaying a deprecation warning. So it's (quite reasonably) just the warning which is bothering you, not that there's a configuration somewhere where that is causing an actual error/failure?

from flexdll.

I apologize. I agree. It is indeed just a warning.

from flexdll.

It this issue to be "fixed" or "by design" please? I just want to get closure on what I should be expecting with upcoming ocaml release and flexdll

from flexdll.

@dra27. May I ask for clarity on above? Fix or not fix If fix: is my change OK?

from flexdll.

The warning will be displayed, as you observe.

Your fix works, but the reason it was written as Pervasives.compare is to be explicit that compare doesn't get accidentally shadowed. So it should really become Stdlib.compare. This will require an update to the compatibility files - Compat407.ml would need to be introduced with a module Stdlib containing the compare symbol.

from flexdll.

Ok. So now what?

from flexdll.

Either wait, or propose a patch!

from flexdll.

Well. I did propose a patch :-). So I will wait. Thank you David for your advice.

from flexdll.