wrong field name in `_refund_cleanup_lines` patch method about rma HOT 4 CLOSED

OK, great. The code for this module can be very ugly, so any improvement is welcome. NOTE: I'm not a user of this module nor proper reviewer for it, but general community manager for this kind of kick-off.

from rma.

Can you please do the PR? https://odoo-community.org/page/Contribute

from rma.

Hey @pedrobaeza . Sure we will, we are reworking this method at the moment.

We have better approach for patching this using index to update values from super and not copy/pasting original Odoo method as there are problems with current approach for example:

• MAGIC_COLUMNS are not excluded like in original method.

We are also thinking that tax_line_ids should be dropped for refund invoice since we noticed problem when refund is made for less lines than original invoice - taxes are wrong (calculated for all lines of original invoice). All this can be easily achieved in this patch method.

If dropped, new tax_line_ids will be recalculated anyway with _onchange_invoice_line_ids

from rma.

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

from rma.