Javascript Style about odoo-community.org HOT 12 CLOSED

I like it. However, basically every line of JS code will violate that standard in OCA, so I don't think it's practical as of today. I don't feel like @elicoidal... 😏

ESLint also offers an additional benefit of being able to catch ES6+ code, which should be forbidden for all Odoo code as of today (see OCA/maintainer-tools#383). In v8-11 versions this saves a lot of hard debugging time with PhantomJS tests breaking the world.

I think that a simple note in the docs that directs to our current ESLint config, which is currently quite hidden, and tells the developer to just install eslint and apply that configuration to know if his code is OK would be better.

Let me ping @OCA/web-maintainers @OCA/website-maintainers @OCA/e-commerce-maintainers.

from odoo-community.org.

I would be in favor but looks like a big leap for the OCA.
To be said that we do not have that many lines in jscript in OCA.

from odoo-community.org.

I think that a simple note in the docs that directs to our current ESLint config, which is currently quite hidden, and tells the developer to just install eslint and apply that configuration to know if his code is OK would be better.

👍 and we may want to update the JS here https://github.com/OCA/maintainer-tools/tree/master/template/module/static/src/js and add a special README/reference on recommended ways to deal w/ JS.

from odoo-community.org.

I like it. However, basically every line of JS code will violate that standard in OCA, so I don't think it's practical as of today. I don't feel like @elicoidal

looks like we agree no? @yajo 👅

from odoo-community.org.

odoo/odoo#28457 (comment)

Information about the standards allowed in v13.0:~

• Production Code: ES5 (2009 - IE11 Support). Can use modern Promise (ES6: Mostly adopted by browsers)
• Test Code: ES8 (2017)

Since Odoo 13.0 ES6 is supported: https://www.odoo.com/documentation/13.0/administration/install/deploy.html#supported-browsers

from odoo-community.org.

@yajo

from odoo-community.org.

@yajo Thanks for ESLint config link!
Surprised that Odoo 13 supports IE11 (https://html5test.com/compare/browser/ie-11/chrome-68/firefox-60/edge-18.html) :S but it's understandable (https://www.netmarketshare.com/browser-market-share.aspx)...

from odoo-community.org.

Odoo 13 is not going to support it officially AFAIK. Odoo 12 does.

from odoo-community.org.

looks like we agree no? @yajo tongue

Yes! I was telling about this part: "we do not have that many lines in jscript in OCA". I feel we have a lot of them! Only that! 😉

Odoo 13 is not going to support it officially AFAIK. Odoo 12 does.

Let me refresh your memory: 😋 OCA/maintainer-tools#383 (comment)

from odoo-community.org.

Let me refresh your memory

Ouch, that hurts! IE11 still...

OK, then it will be Odoo 14 when we will be able to standardize JS guidelines.

from odoo-community.org.

Hello guys, would like you to help me how to use datatable on odoo, please

from odoo-community.org.