Git Product home page Git Product logo

Comments (6)

alexis-via avatar alexis-via commented on August 23, 2024

@rousseldenis Glad to see that you are playing with weboob :) I was talking about weboob with my collegues @bguillot and @florian-dacosta this morning, saying that we should try to learn how to develop a weboob module to download invoice (I haven't tried it myself yet).

I don't understand your point about weboob extracted in a "separate" module : weboob already has it's own module account_invoice_download_weboob and weboob itself is an external python lib. So I don't really see what more we could extract. Maybe you mean that the module "account_invoice_download" should handle both invoices and purchase orders... is it what you mean ?

About unece : I don't think it's a problem that base_business_document_import pulls unece. These unece are small modules that just provide fields and data, nothing more. If you don't need them, they won't "bother" you. And I hope that this kind of data will become native in Odoo v13 or v14, so that we won't have to maintain these modules in OCA any more.

from edi.

rousseldenis avatar rousseldenis commented on August 23, 2024

@alexis-via I wanted to put this implementation of weboob in Odoo

class WeboobModule(models.Model):
in a separate module.

And maybe abstracting this too : https://github.com/OCA/edi/blob/10.0/account_invoice_download_weboob/models/account_invoice_download_config.py

For 'unece', it was just a question on dependency, but if it will be standard, ...

from edi.

alexis-via avatar alexis-via commented on August 23, 2024

Yes, why not...

For curiosity, do you really have a real-life scenario where you would have to auto-download sale orders (in your first comment, you mentioned purchase orders... but it doesn't really make sense to get a PO from a remote location !) from a remote website ? It is very common for invoices (electricity bill, phone bill, Internet bill, ...), but I don't see this kind of scenario for sale orders: usually, the customer pushes the sale order to this supplier, he doesn't wait for him to come and get it from his web portal. I'm not against splitting the module in 2, but if it doesn't correspond to any real-life scenario, I think it's not worth the effort. We'd better invest the equivalent effort in improving the module or developping additional weboob invoice modules !

from edi.

rousseldenis avatar rousseldenis commented on August 23, 2024

It was an example. But, the idea was not limiting weboob usage to invoices as it can parse almost everything.

from edi.

alexis-via avatar alexis-via commented on August 23, 2024

If you do this extraction, I'll approve your PR :)

from edi.

github-actions avatar github-actions commented on August 23, 2024

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

from edi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.