Clarification and Enhancement Request for Financial Risk Security Groups about credit-control HOT 1 OPEN

I want to clarify that this only applies to Odoo 16+ because it was in this version that Odoo added the credit limit feature in odoo/odoo#83205. In previous versions there might still be some inconsistency, but we didn't check.

Views should be managed with standard permission: billing, full accounting and accounting manager

I agree.

Indeed this permission level seems to be completely useless now:

By removing it, we'd be able to undo the inconsistency. This way, also, installing other modules that used that core Odoo feature would be able to follow core permissions model without having to deal with the fact that there's an OCA module that introduces a separate permissions model.

Approve or not a sale or invoice which is blocked by exceded risk should be manager with a special security group as is in this moment with Financial Risk Manager

This also seems a good solution to me. It's about this permission, and it is still useful:

These users will be able to:

• Set up specific limits (not warnings, like upstream Odoo does (although they call them limits)).
• Skip those limits in specific occasions.

However, be warned that any other billing/full-accounting user would still be able to edit the global limit, just like with upstream Odoo. This is a bit inconsistent too, but at least it seems the lesser evil, given the current situation.

The module account_financial_risk would be adding that group and at the same time giving it some functionality, so it makes sense in that regard too.

Thanks for the analyisis and detailed explanation @rafaelbn.

from credit-control.