Git Product home page Git Product logo

Comments (8)

slandelle avatar slandelle commented on August 16, 2024 1

This is a bug with Jodd's IE conditional comments support:

<html><head>
<!--[if lte IE 9]><meta http-equiv="refresh" content="1;url=/2.218.0/static/unsupp.html" /><![endif]-->
<!--[if gt IE 9><!--><script>alert("Hello!");</script><!--<![endif]-->
</head>
</html>

The first line works fine, the second one crashes with IOOBE.
A possible workaround is to disable IE conditional comments support in Lagarto config.

from jodd.

igr avatar igr commented on August 16, 2024 1

I checked the code, you didnt make mistake @slandelle

from jodd.

slandelle avatar slandelle commented on August 16, 2024 1

Regular comment IMHO

from jodd.

igr avatar igr commented on August 16, 2024 1

Releasing new version @slandelle atm :)

from jodd.

igr avatar igr commented on August 16, 2024

Thanx @slandelle for fast detection! It seems that the second line has the syntax error for Conditional Comments, i.e. its missing the ]. I guess that in this case this is not a conditional comment, but regular one. Jodd should 'roll back' the conditional condition parsing and go with comment (just need to verify what happens in browser... internet explorer, anyone?:))).

from jodd.

slandelle avatar slandelle commented on August 16, 2024

Let me check if I didn’t introduce a typo when simplifying cnn.com HTML content.

from jodd.

igr avatar igr commented on August 16, 2024

if I assume that [if gt IE 9> is a regular comment, should Jodd emit conditional comment on endif or regular comment (as the starting conditional comment does not exist)?

from jodd.

slandelle avatar slandelle commented on August 16, 2024

Thanks mate!

from jodd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.