Support for different handling of nested null properties about jodd-util HOT 17 CLOSED

Hi.
I was thinking different exception type. I'm trying to replace apache beanutils, and they throw a NestedNullException in case some of the nested params was null. But it would work with a flag or something in the BeanException, like: "boolean nestedNull", that says a property chain had a null value somewhere. Because otherwise all lib users need to add another checked exception.

What i'm looking for is to be able to just return null if any of the nested properties are null, but detect incorrect property names and throw exceptions.

Hmm, i tested hasProperty but both returned false!

X bean = new X();
System.out.println(BeanUtil.declared.hasProperty(bean, "nested.a")); // false
bean.nested = new Y(); // Nested must be inited first!
System.out.println(BeanUtil.declared.hasProperty(bean, "nested.a")); // true

from jodd-util.

Hi. I think the behaviour in:

nested.a -> null exception
nested.b -> not found exception
nested.a.foo -> null exception (!!!)

is good enough!

from jodd-util.

Hi,and thanks a lot!

I tested the snapshot and it worked fine, except for one test case i had.
Writing through a null property throws jodd.bean.exception.PropertyNotFoundBeanException.
I think for symmetry it should throw NullPropertyBeanException, what do you think?

My tests look something like this:

 //This passes
    @Test(expected=NullPropertyBeanException.class)
    public void test_utils_read_through_non_nulls_2()
    {
        X bean = new X();
        BeanUtils.getValue(bean, "nested.a");
    }
    
 //This fails with java.lang.Exception: Unexpected exception, expected<jodd.bean.exception.NullPropertyBeanException> but was<jodd.bean.exception.PropertyNotFoundBeanException>

@Test(expected=NullPropertyBeanException.class)
    public void test_utils_write_through_nulls()
    {
        X bean = new X();
        BeanUtils.setValue(bean, 5, "nested.a");
    }

from jodd-util.

Absolutely! Hold my beer... coding it :)

from jodd-util.

👋

Make sense! When you say "different exception", do you mean A) a different exception type or B) simply a different message?

Somewhat related: note (in case you didnt know) there is a function that detects existence of a property:

System.out.println(BeanUtil.declared.hasProperty(new X(), "nested.a")); // true
System.out.println(BeanUtil.declared.hasProperty(new X(), "nested.b")); // false

Thank you for the feedback!

from jodd-util.

Cool, I can refine the exception types - add different subtypes, including the new one for your case.

p.s. I will check the example with hasProperty, I am pretty sure it worked this morning :)

from jodd-util.

Under development, this week is just crazy :(

from jodd-util.

It's cool, take your time! I will be happy to test it out =)

from jodd-util.

@siggemannen

The issue I am facing is this: in both cases, the nested of the new X() is null. BeanUtil simply stops there, not capable to continue any further. Since this is the same cause, the same exception would be thrown.

Otherwise, we would need to validate the whole path. This validation is not guaranteed, as it might depend on runtime (for lists, maps etc). Next, the whole path could be longer, e.g. nested.a.foo -> this one should throw the same exception as nested.b, right?

Note that the following works:

assertTrue(BeanUtil.declared.hasProperty(new X(), "nested.a"));
assertFalse(BeanUtil.declared.hasProperty(new X(), "nested.na"));

What I can do is to actually only cover the case of the immediate child: nested.foo when nested is null. So:

nested.a -> null exception
nested.b -> not found exception
nested.a.foo -> null exception (!!!)

wdyt?

from jodd-util.

Here it is, the test is passing... I will release a snapshot for you to try it

from jodd-util.

The snapshot is published (hopfeully:)

from jodd-util.

Done, releasing during the day (need to migrate from travis, damn :(

from jodd-util.

Snapshot published 🍭

from jodd-util.

Awesome! It works for me now. Many thanks. If you have time to do a specific snap for the jodd.bean-package, it would be cool! But i can wait for proper release too

from jodd-util.

6.1.0 released :)

from jodd-util.

Just a little followup. I've now been running BeanUtils and it works great =) Thanks a bunch

from jodd-util.

Glad to hear so!!!

from jodd-util.