Comments (6)
lukaw3d
commented on June 21, 2024
1
I checked and cut-off for the nicer transak layout is 601px (currently we are using 500px, following their docs)
So we could also have slightly wider Box center
from oasis-wallet-web.
donouwens
commented on June 21, 2024
@lukaw3d - Is the thought behind more contrast to emphasize the Transak widget is from an external party?
from oasis-wallet-web.
lukaw3d
commented on June 21, 2024
Yes, and make it clearer where the third party content ends
from oasis-wallet-web.
tjanez
commented on June 21, 2024
Thanks for the visuals of some alternatives, @lukaw3d!
I like the Box left and Box center variants.
I'm just wondering if it would be possible to somehow "connect" the Transak frame (with the warning banner) with the box above:
Buy crypto to your wallet
This feature allows you to convert your fiat currency into cryptocurrency.
since they belong together logically?
from oasis-wallet-web.
donouwens
commented on June 21, 2024
I think the box center works best to achieve this. Box left looks better but also feels more part of our wallet and since want to achieve a stronger emphasis on the widget being third party we probably don't want that.
from oasis-wallet-web.
tjanez
commented on June 21, 2024
I like the reasoning behind Box center that @donouwens gave. Perhaps we should re-consider wide as well since somehow the Transak widget behaves a bit nicer there (e.g. "Buy now" button is not so far down)?
from oasis-wallet-web.
Related Issues (20)
- Trim 0x from the Ethereum Private key
- Replace the mobile icon + splash with new name HOT 4
- E2E test "recover from fatal errors" is flaky (at least locally)
- Toolbar layout breaks at 769 width HOT 1
- Refactor Navigation (Sidebar) and Toolbar
- Received tokens not spendable until reimport HOT 1
- Cipher deposit fees have increased
- “This is not your account” HOT 5
- Can we remove dappFrameAncestors
- Update footer text HOT 1
- Extension layout: copying an address moves content HOT 1
- Create Profile form validation HOT 2
- Select active network in dropdown
- Replace deprecated GitHub action HOT 1
- Do we need to check chrome.runtime.lastError when popup opens HOT 3
- Fix updating transactions list HOT 3
- Select accounts to open modal lacking validation message HOT 2
- Simplify codebase without incognito mode
- Move mobile footer to Profile Settings HOT 1
- Disable input number scrolling changes
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from oasis-wallet-web.