mercurial support about onefetch HOT 8 CLOSED

@VitalyAnkh This just happens automatically to help clean up issues: https://github.com/o2sh/onefetch/blob/5a632825fc5c2e9a68de6830c54a4626b8371c16/.github/workflows/stale.yml

Now that you've added a comment, IIRC the stale label should get removed on the next scheduled run 🙂

Anyway, adding mercurial support would be a pretty large undertaking for us, and I think we'd want

• someone who is very familiar with mercurial
• discussion about how to rearrange the code (detecting VCS instead of assuming git, implementation and organization, etc.)

Before we even start implementing code changes for this.

Step 1 for adding mercurial support will be making Git optional IMO, which is significant enough to deserve its own PR. @o2sh What do you think about making Git optional?

from onefetch.

In addition to making Git optional, it would require a Rust library like gitoxide, but for Mercurial, to parse the necessary repository information, which doesn't exist AFAIK

Unfortunately, Mercurial does not appear to be too popular.

from onefetch.

Somewhat related: #860

I think that if we start supporting VCS besides Git, we'll need to consider some sort of refactoring to make fetching repo stats more plugin-like.

Although we can kind of get "universal support" by simply allowing non-Git repos, and just disabling any git stats.

from onefetch.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

from onefetch.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

It's a feature request. Why stale since it's not implemented?

from onefetch.

Sounds good to me. With how much we export, it honestly shouldn't be too hard for a Mercurial user to write a separate tool mimicking our behavior.

from onefetch.

FYI if #1152 gets merged then I think it's pretty much guaranteed that we won't support Mercurial. Though adding Mercurial support to gengo does sound fun... 🤔

from onefetch.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

from onefetch.