Git Product home page Git Product logo

Comments (5)

Avnerus avatar Avnerus commented on May 30, 2024

Hey!
So on the loaders.gl side, a tile is not selected unless its content is loaded, and a tile does not mark its content as 'ready' until the external async function (in our case using three js) is done, .
So this error should not appear.

from three-loader-3dtiles.

2226174644 avatar 2226174644 commented on May 30, 2024

I see.Thank you for your so quick reply!
By the way,there is another little question :
Here, unloadQueue is used to contain the tiles that need to be unloaded;
And we dispose the tiles in the tilesetUpdate.
In this case,the gltfNode can't be disposed immediately. I wonder why not delete the gltfNode directly when the onTileUnload callback but put it in the next tilesetupdate?

from three-loader-3dtiles.

Avnerus avatar Avnerus commented on May 30, 2024

I found this method to be the most reliable, ensuring that no race condition occurs in which a tile is unloaded while it is still being processed. However, it has been a while since that code was written and it might be that directly disposing the tile would work fine. If you would like to try it and see if it improves performance reliably then I am happy to accept a PR for this.
Thank you!

from three-loader-3dtiles.

2226174644 avatar 2226174644 commented on May 30, 2024

Make sense!
And I have tried to dispose gltfNode in the onTileUnload.There is no error about race condition occurs at present.Also ,I don't feel any significant improvement in performance for the time being.
All in all ,I think your approach is reasonable and safer. Thank you for taking the time to guide me!

from three-loader-3dtiles.

Avnerus avatar Avnerus commented on May 30, 2024

OK, great!
Thank you for the feedback.
I will close this issue for now, but feel free to re-open or propose a PR if you mange to get some improvement.

from three-loader-3dtiles.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.