Git Product home page Git Product logo

Comments (8)

step21 avatar step21 commented on May 21, 2024 1

Confirmed.

from nylas-mail.

step21 avatar step21 commented on May 21, 2024

I kinda tried to get this working. It more or less works, except somehow when skipping platform specific packaging, grunt does not accept registering only 'package' or nothing as a task instead of the platform specific packaging. Any idea why this could be? It can be forced with --force but of course that is not optimal.
Edit (Details):
I defined a new command 'build-client-only' though maybe your name is better. This then sets a --package/--no-package flag for grunt that is parsed and based on this the existing package tasks are set or not. Only problem as said above is, that when skipping the existing tasks it complains about not finding the build-client task.

from nylas-mail.

dweremeichik avatar dweremeichik commented on May 21, 2024

I think it should be able to be done simply with npm start. The docs may need to be updated to be more specific as to what does what.

from nylas-mail.

step21 avatar step21 commented on May 21, 2024

Well, I based this on the procedure in docs/guide/contributing/installation.md This requires manually running npm build-client. Do you mean that npm start (which is npm run client) runs npm run build-client automatically?

from nylas-mail.

step21 avatar step21 commented on May 21, 2024

After looking into this and confirming with @dweremeichik in another thread, it seems this can be closed as build-clientis basically package-client. If anything, this should maybe be clarified in the docs, that this does not actually build, but package.

from nylas-mail.

mikeseese avatar mikeseese commented on May 21, 2024

This would mean that you can do npm start or npm run client without running npm run build-client on a fresh clone?

from nylas-mail.

step21 avatar step21 commented on May 21, 2024

This should be the case, yes. I can test it again just to be sure.

from nylas-mail.

mikeseese avatar mikeseese commented on May 21, 2024

Closed as this issue is not applicable

from nylas-mail.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.