Git Product home page Git Product logo

Comments (3)

rowanseymour avatar rowanseymour commented on July 18, 2024

It might be sufficient/simpler to communicate back to the caller the "level" of error. For example I see 3 different error levels:

  1. An error (warning?) may have occurred but the show goes on (e.g. expression evaluation, maybe user didn't mean for something to be an expression)
  2. An error occurred so this action is being skipped but the show goes on (e.g. your webhook URL was an expression that evaluated to an empty string)
  3. A fatal error because your flow can't be run (e.g. this switch test doesn't exist)

from goflow.

rowanseymour avatar rowanseymour commented on July 18, 2024

Just noting that the way we're currently going with this is that there are essentially 4 kinds of error:

  • Server error: Internal things, e.g. server runs out of memory.
    • Returned to the caller as an error response with message (500)
    • Caller can retry the same call later
  • Request error: These are things that we will try to catch at the validation stage of a request, e.g. structural problems in the flow.
    • Returned to the caller as an error response with message (400)
    • Caller shouldn't retry the same call
  • Fatal runtime error: These are things which we can't detect at the validation stage but also can't continue from, e.g. loop detected
    • Session and run are given status=errored and event log contains an error event
    • Caller can't resume this session
  • Non-fatal runtime error: These are more things which we can't detect at the validation stage but can safely ignore and continue from, e.g. template evaluation problem
    • Event log contains an error event
    • Caller can ignore or surface the error to the user (e.g. in simulator window)

from goflow.

rowanseymour avatar rowanseymour commented on July 18, 2024

Closing this as much has changed. We no longer have a flowserver - mailroom is calling goflow directly so there's no scope for server/request errors.

But we do have error and failure events (fatal error that prevents flow contiuation)

from goflow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.