Support for non-contact preferred language about goflow HOT 7 CLOSED

Oh so this is a flow with multiple languages, but we want to cascade from contact->org->flow default language when looking up a translation?

from goflow.

Yup, exactly.

from goflow.

How do we feel about this approach instead - we use org.primary_language as the default for unset contact languages: https://github.com/nyaruka/rapidpro/blob/b14a246e0dcf31adbb70124f0bdf041f1ac4f33a/temba/contacts/models.py#L484-L484

The upside is goflow doesn't have to know about another thing which can have a language - the downside is we can't implement a "clear language action" so easily - but I'm not sure how useful that is anyway (just set it to your org primary language instead) and it's not something we currently support.

Whatever we do here, we'll want to do something similar for org.timezone vs contact.timezone.

from goflow.

The impetus behind the existing behavior is that flows can have various language support and travel about different accounts which may have different primary languages. Since localization of 100% isn’t required we need reasonable fallbacks. The case we are trying to support is which of the flow’s languages to use if the contact’s primary language is not present, not necessarily just not set.

I do appreciate the simplicity of this suggestion but it’s really not at all the same thing. If we went down this path, to me it’s more appropriate to let the flow dictate backdowns and to remove the concept of a primary org language altogether.

from goflow.

That makes sense - so I guess we need pass something like environment to goflow which has a language (and probably a timezone).

Or make Contact.languages a list? RapidPro would populate it as [contact.language, contact.org.primary_language] but goflow would support an arbitrary list of languages to try.
SetLanguageAction would add a language to the start of the list. There's nice flexibility to letting contacts have their own backdown languages.

from goflow.

Ya, since the engine operates on contacts and knows nothing of orgs, I think it makes sense to put whatever is needed there. A list of languages on contact makes the most sense to me.

from goflow.

Closed via #52

from goflow.