preview vim_buffer lnum issue about telescope.nvim HOT 8 CLOSED

Is this still ongoing bug? @rockerBOO @bryall

from telescope.nvim.

it still exists in the code, basically the minus one in the buffer previewer needs to be removed and then double check all who use the buffer previewer to check to make sure they have the correct modifications when creating their entries

from telescope.nvim.

Previewers got completely rewritten and that should be fixed now. Can you confirm? Thanks :)

from telescope.nvim.

this bug is still present,

on line 535 in the make_entries file, the tree sitter has to do a "entry.lnum - 1" to have the correct line number. tree sitter should not have to do this.

from telescope.nvim.

Okay so now its tree-sitter :) I agree with you that should not happen here.
But buffer and lsp work should be good right?

Edit: Also thanks for testing all that :)
Edit 2: Line removed in #382

from telescope.nvim.

Any problems with this now? Or can we close?

from telescope.nvim.

this issue was created because we had to add 1 to the line number when making entries. As far as I know we still need it for tree sitter to work correctly. If my memory remembers correctly, Lsp needed to subtract one when making entries and this plus one was to overcome it.

I am find if you want to close this issue, since it is working, the issue was created to make the code better and more clear

from telescope.nvim.

Closing this issue, its too general and we have no + 1s left in the previewer that are an issue.

The treesitter +1 is still there but its inevitable and the lsp stuff does not have any -1 afaik

from telescope.nvim.