Git Product home page Git Product logo

Comments (4)

benbarsdell avatar benbarsdell commented on August 29, 2024 2

I believe the root cause of this is the #include <climits> header being loaded from jitify's builtins and cached, and then, when #include "climits" is encountered within libcu++, jitify uses the cached version instead of the new one.

The solution will be to distinguish between #include <foo> and #include "foo" in the header cache. However, it is further complicated by the fact that NVRTC does not support such a distinction. I think the only way around that will be to automatically patch #include "foo" to #include </path/to/foo> (if and only if /path/to/foo exists).

Unfortunately this is easier said than done, which is why I haven't got to it yet.

In terms of workarounds, removing #include <limits> and just using the libcu++ version should work, if that's doable in your code. There may be other workarounds too.

from jitify.

maddyscientist avatar maddyscientist commented on August 29, 2024

@benbarsdell this is the same issue I reported a while ago. Did you have a chance to think about how to fix this?

from jitify.

benbarsdell avatar benbarsdell commented on August 29, 2024

I'll see if I can take another look at this later this week.

from jitify.

bdice avatar bdice commented on August 29, 2024

@benbarsdell Hi, any updates on this? I'm reviewing rapidsai/cudf#11287 and would like to understand the issue / what solutions might be possible.

from jitify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.