On Vercel, Nuxt v3.11.2 causes infinite redirect when query string contains `+` is passed about nuxt HOT 14 CLOSED

This happened to me in the past when including characters like / or + too. Not sure if this is a regression but these issues mention it:

#14316
#15738

from nuxt.

Yes - and let's add a comment there.

from nuxt.

FWIW I think #26519 is what introduced the bug in 3.11.2. Specifically this line:

In my testing on Netlify given an example dynamic path /post/1?foo=bar/, the nuxtApp.ssrContext.url has encoded the query string, but the router fullPath does not:

initialURL = /post/1?foo=bar%2F
to.fullPath = /post/1?foo=bar/

Therefore the line !isSamePath(to.fullPath, initialURL) is returning true when it should be false. I was able to patch this by using decodeURIComponent(), although I'm not sure if that is the perfect solution here.

!isSamePath(to.fullPath, decodeURIComponent(initialURL)))

Perhaps Vercel and Netlify both encode values passed differently (encodeURIComponent vs encodeURI?), which might explain why a query string with + works on Netlify but not Vercel.

from nuxt.

Nice find - thank you @abovedave 🙏

from nuxt.

We are having a similar issue, but I'm not sure if it's exactly the same thing. A couple of questions...

1. I tried the nightly build and the issue persisted, should that have worked? Would that actually be a temporary solve for this?
2. our route works fine on localhost in a web browser, but we have some software that uses an integrated Edge browser, and it gets redirected infinitely there until a "too many redirects" error (using localhost as well). The query string that seems to cause it doesn't have any '/' or '+' characters (http://localhost:3000/?mode=light&ver=1.1.1.1&Mode=active&id=ffb738944d621ac08a1802c6a92ad5d69a625800&font=Segoe%20UI). Does this warrant its own issue, or does it seem similar enough?

from nuxt.

I've encountered this error before and it reappeared after an upgrade. This hotfix resolves the issue:

#14316 (comment)

from nuxt.

It was working fine until 3.11.1 and went wrong from 3.11.2, so it should be a recurrence

from nuxt.

cc @huang-julien might be related to the encoding? #26712 ?

from nuxt.

Similar thing happening on Netlify with /, + works though #26888

from nuxt.

I think we'll revert the encoding. wdyt @danielroe ?

from nuxt.

I was just looking to patch our site with the fix in #26893 until it's released, but it looks like the work which was reverted from #26712 hadn't even shipped yet and was scheduled for 3.12.0 - so I'm confused at the fix here, unless I missed something?

from nuxt.

You can use nightly version to for the patch, or you can also just downgrade to v3.11.1

https://nuxt.com/docs/guide/going-further/nightly-release-channel

from nuxt.

Re-opening here for further investigation (cc @danielroe)

from nuxt.

@calbers-ew if it's this bug causing your issue, downgrading to 3.11.1 should fix it for now.

from nuxt.