test/unit-tests.c GCC13 compilation error, dangling-pointer about libvfio-user HOT 5 CLOSED

I think it needs to clear vfu_ctx.migration back to NULL before returning, since vfu_ctx is a global variable.

@kgodzwox, can you confirm this patch fixes the issue? If so I'll create a pull request for it.

diff --git a/test/unit-tests.c b/test/unit-tests.c
index cdb88a2..81e53ca 100644
--- a/test/unit-tests.c
+++ b/test/unit-tests.c
@@ -601,6 +601,7 @@ test_device_is_stopped_and_copying(UNUSED void **state)
             assert_false(r);
         }
     }
+    vfu_ctx.migration = NULL;
 }

 static void

from libvfio-user.

@jimharris I confirmed your patch fixes compilation.

from libvfio-user.

I also confirm this

from libvfio-user.

#735

from libvfio-user.

The pull request was merged, this issue can be closed. Thanks!

from libvfio-user.