Git Product home page Git Product logo

Comments (4)

sholderbach avatar sholderbach commented on August 22, 2024 1

When reproducing I also noticed that the move up displayed the second last entry from the history
image

from reedline.

nixypanda avatar nixypanda commented on August 22, 2024 1

these problems have been introduced with the last commit; in fact if you run:

I believe the disappearing of history commands already existed with ctrl-R search, and the unification got this into prefix search as well.

from reedline.

nixypanda avatar nixypanda commented on August 22, 2024

These are most likely introduced by #92, which I worked on earlier.

Problem

Cursor position update

Potential Culprit

https://github.com/jntrnr/reedline/pull/92/files#diff-ff278ec599adfd033d35a083ebe8948db8bf177c9817dee8ddc4f3a9e3f5728eR694.

Potential Fix

  • Probably this function should handle the update to the cursor.
  • Afterwards, if there is a char insert we copy over the history result to line_buffer.

Problem

Last entry is not shown

Potential Cluprit

hitting back calls the previous history, which increments the cursor position.

Potential Fix

display first then perform move. Thoughts?

Problem

History command disappear after few seconds

I am not sure why this could be happening. Probably the clock update flushing history traversal state.

I really should have added more tests to engine as well

from reedline.

mzanrosso avatar mzanrosso commented on August 22, 2024

@sherubthakur Yes, these problems have been introduced with the last commit; in fact if you run:

git checkout main
git reset --soft HEAD~1
git stash ; git stash clear
cargo run

You will notice that these problems have disappeared

from reedline.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.