Git Product home page Git Product logo

Comments (16)

sholderbach avatar sholderbach commented on August 22, 2024 32

Voting on the feature areas you want the project to focus on

Vote for the topic(s) you care about by selecting the corresponding emoji. (No judgement based on the emojis sentiment!)

  • 👍 Prompt #64
  • 👎 Completions #65
  • 😄 Hints #65
  • 🎉 History #66
  • 😕 Syntax Highlighting #67
  • ❤️ Pop-ups/Annotations #68
  • 🚀 Keybindings #69

from reedline.

fdncred avatar fdncred commented on August 22, 2024 3

Thansk @sholderbach. Here's another feature that needs to go in some category.

  • Ability to integrate with fzf, skim, broot, zoxide, ranger, etc

from reedline.

sholderbach avatar sholderbach commented on August 22, 2024 1

As the granularity/scope of the ideas/milestones varies we may want to break the main themes out into separate tracking issues under a milestone so that we can better keep track what is relevant in that area. We than can use the one here to weigh on the focus of the general themes. Using the emojis on github with individual comments would probably get quite messy.

from reedline.

sholderbach avatar sholderbach commented on August 22, 2024 1

I would like to add the category 'System interaction' including stuff like compatibility validation on ssh, tmux etc.

There it would fit in. Where is the responsibility boundary between line editor and integration with nushell?

from reedline.

fdncred avatar fdncred commented on August 22, 2024 1

@sherubthakur This is what I meant by this item in the history list above. Maybe I should've named it Prefix based search

  • Ability to search history and travese backward and forward within the search criteria

from reedline.

sholderbach avatar sholderbach commented on August 22, 2024

How should we vote or state our priorities?

from reedline.

fdncred avatar fdncred commented on August 22, 2024

Good question. Any suggestions? It would be nice to allow people to upvote certain things. Maybe there's some voting site that does that?

from reedline.

jntrnr avatar jntrnr commented on August 22, 2024

One way to do the voting would be to let people pick their top three things, then count that. Folks could reply here if we do it that way.

from reedline.

fdncred avatar fdncred commented on August 22, 2024

@sholderbach I was going to split this up into issues like you did (Thanks!!!) but what do you think about adding the github emojis to allow people to vote by clicking on them? I think we just need to maybe number them and say to vote for X use the +1/thumbs up emoji, to vote for Y use the -1/thumbs down emoji. I just see 8 emojis so maybe we can only have the top 8 things to vote on. What do you think?

BTW - i added to History - ability to remove history

from reedline.

sholderbach avatar sholderbach commented on August 22, 2024

My suggestion would be to put a list of the eight currently most important/controversial ideas in a comment below with the emojis as labels, so we can update the top comment as an overview as needed without screwing with the past votes.

Template below:

Current voting

Vote for the topic(s) you care about by selecting the corresponding emoji. (No judgement based on the emojis sentiment!)

  • 👍
  • 👎
  • 😄
  • 🎉
  • 😕
  • ❤️
  • 🚀
  • 👀
# Current voting

Vote for the topic(s) you care about by selecting the corresponding emoji. (No judgement based on the emojis sentiment!)

- :+1: 
- :-1: 
- :smile: 
- :tada: 
- :confused: 
- :heart: 
- :rocket: 
- :eyes: 

from reedline.

fdncred avatar fdncred commented on August 22, 2024

Speaking of validation, there may need to be some type of Validator trait like rustyline's.

from reedline.

fdncred avatar fdncred commented on August 22, 2024

Since these are all referenced in their own issues, I think I'm going to close this one to declutter. We can re-open if needed.

from reedline.

fdncred avatar fdncred commented on August 22, 2024

oops, didn't notice it was pinned. Reopening. :)

from reedline.

sherubthakur avatar sherubthakur commented on August 22, 2024

Idea: Prefix based history search.

Example use-case:
(assuming you are using vi mode)

  1. Your start writing a command dock
  2. Hit escape and start going through history using k
  3. you will get suggestions like docker ls docker-compose ls docker-compose logs etc.

Note: adding this separately from 'history search based on a criteria' as one doesn't need to hit Cmd-r (or equivalent) for this.

from reedline.

hustcer avatar hustcer commented on August 22, 2024

In bash we can do :

nu \
  -c 'version'

to break lines, maybe we can add this feature too.

from reedline.

sholderbach avatar sholderbach commented on August 22, 2024

In bash we can do :

nu \
  -c 'version'

to break lines, maybe we can add this feature too.

This is beyond the scope of reedline as special casing characters in the buffer would constrain the grammar of the using language (nu might not want to adopt the backslash bashism as it is annoying with Windows paths). The Validator trait can be implemented to do checks whether an expression is complete. The submit on enter check could be extended on reedline's side to provide option to only submit on the last line/last char position.

from reedline.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.