No submit icon in verification dialog (regression) about twofactor_email HOT 18 CLOSED

Yes. But 2.2.0 is in final testing, too 🎉

from twofactor_email.

It looks like this is on purpose, but I disagree with the change.

Almost every person the first time they use this has come to me asking how they login because there is no button to press.

This is also a bigger issue when using the mobile app because hitting Enter on mobile isn't as natural as on a PC. You have to click back into the field then hit Return on the virtual keyboard.

You can see the developer mentions it in the wiki Developer Notes "I adopted the login dialog style (no "Login button") to the challenge dialog. Shall there be a "Press Enter" hint?". Did Nextcloud remove the Login button at some point too? It seems to be there on Nextcloud 22, so they must have added it back. It seems like this is one of those changes for a new minimalist trend, but this is just silly when you remove a functional button completely and leave the person to only be able to continue by hitting Enter.

from twofactor_email.

Yes, I also have all the users complaining that they couldn´t login.
Personally I've never stepped into a contact form without any submit button before.
Amd it's also bad on mobile, like you said.
It would be great to revert back to the icon, like, If I've understood correctly, nextcloud did

from twofactor_email.

This is what it looks like after applying the PR:

from twofactor_email.

2.0.1 should do.

from twofactor_email.

I manually reverted back to 2.0.1 and everything is back to normal.

I've also noticed that with version 2.1.1 the mail icon is much bigger than the 2fa otp icon, which is not the best from the aesthetic standpoint.
For now I will try to stay on 2.0.1 .
I'm I really the only one experiencing this problem?
Thank you!

from twofactor_email.

Hi guys, thanks for the heads up and sorry for the delay – my notifications were misconfigured by accident…

Yes, the change was on purpose. I followed the NC login (at least I think a NC beta by that time also had no button. The current "Two-Factor Gateway" (SMS) login today has none. There is no UX pattern guideline I know of (please point me to it if you know of one!) and app's logon layouts today are inconsistent.

Personally, I think that it is well possible and logical to use an enter button. Mobile and desktop browsers both boast some kind of keyboard which I assume to be active while entering (or pasting) the code. There are three ways to go:

1. Leave it as is (probably add descriptive text to use the keyboard's ENTER key)
2. Implement something that verifies as soon as 6 digits have been entered (or pasted)
3. Reverting to an "Send button" solution (while allowing to alternatively press ENTER)

From the user feedback and discussion with other devs I agree that 1. is technically sufficient and (in my opinion not too) minimalistic, yet users struggle with it. I don't like 2. because it can lead to unintended verifications.

I intend to implement 3. and follow the Two-Factor TOTP app layout and wording. It has a big descriptive button. I need to figure out how to allow for the ENTER key (I think not being able to achieve that was part of my design decision in autumn). Help with that appreciated.

Here's an overview of current 2FA login dialogs:

It may take a while until I release a new version (at least until first NC24 betas are out) to package and publish it.

from twofactor_email.

I also had a problem with github notifications and I've missed your reply.
The new version looks great, good choice. I'm looking forward to updating to your last version.
Thank you

from twofactor_email.

@nursoda
I had to update nextcloud and the installation also automatically updated the Two-Factor Email app. Now the icon to fill in the code is again missing :(
I can't go back to the old version and as from tomorrow my users will complain again...

Do you have any plan to release the version you posted here n February?

Thank you very much again!

from twofactor_email.

I advise you to roll back to the last app version you had installed. All released apps still are available via GitHub.

I currently cannot release an update due to broken vue dependencies. If anyone is willing to help out fixing those, I'll be happy to release this weekend. Pleas PM me if you have some experience with vue 2->3 migration.

from twofactor_email.

@nursoda
Thank you for your reply.

I'll try to manually install to an older app version by downloading it from github.
Do you by chance remember which was the last version that was including the send icon? I'm not sure between v2.0.0 and v2.0.1.

I would be really glad to help but unfortunately I don´t have any experience with vue, I just hope someone else could help. Btw, shouldn´t this issue be open (since the new version is not yet released)? It shows as closed at the moment.

Thank you very much for your work!

from twofactor_email.

2.0.1 should do.

Thank you! I will try to install the old version as soon as possible

from twofactor_email.

@nursoda can we use 2.0.1 with NC 23 ?

from twofactor_email.

All right! that's awesome news. cant wait to check it out.

from twofactor_email.

Yes. But 2.2.0 is in final testing, too tada

great news!

from twofactor_email.

2.2.0 published on GitHub and in App Store. Please reopen if it doesn't work as expected.

from twofactor_email.

Just tested looks good no issues from my end :) thank you

from twofactor_email.

@nursoda It works perfectly. Thank you so much!

from twofactor_email.