Git Product home page Git Product logo

Comments (10)

breznak avatar breznak commented on July 25, 2024

@scottpurdy do I take your comment (on some PR) as remove these mytype var >= 0 checks globally? If so, we can remove the Wno-type-limits flag and start fixing these. It'd be trivial but long..

from nupic.

rhyolight avatar rhyolight commented on July 25, 2024

@breznak Still a valid ticket?

from nupic.

breznak avatar breznak commented on July 25, 2024

yes, still waiting for advice from others before taking up the simple but
long work.

from nupic.

rhyolight avatar rhyolight commented on July 25, 2024

@scottpurdy Do you have any input?

from nupic.

scottpurdy avatar scottpurdy commented on July 25, 2024

I support this.

from nupic.

breznak avatar breznak commented on July 25, 2024

logic moved to nupic.core

from nupic.

rhyolight avatar rhyolight commented on July 25, 2024

logic moved to nupic.core

@breznak what do you mean?

from nupic.

breznak avatar breznak commented on July 25, 2024

@rhyolight the c++ code is now in nupic.core repo, this issue is from '13. So I will just enable Wextra and call this closed.

from nupic.

rhyolight avatar rhyolight commented on July 25, 2024

So I will just enable Wextra and call this closed.

Is there a PR for this?

from nupic.

breznak avatar breznak commented on July 25, 2024

@rhyolight closing as the checks have been fixed somewhen inbetween. and Wextra added in numenta/nupic.core-legacy#273

from nupic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.